Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undocumented dependency withr >=2.4.0 #445

Closed
stroberts opened this issue Nov 24, 2021 · 3 comments
Closed

Undocumented dependency withr >=2.4.0 #445

stroberts opened this issue Nov 24, 2021 · 3 comments

Comments

@stroberts
Copy link

stroberts commented Nov 24, 2021

Hi there, don't have time to document this as thoroughly as I'd like, but I have some strong indicia that the latest version of mice (v3.14.0) has a dependency on withr >=2.4.0, which is not specified in the DESCRIPTION file. Specifically I encountered issues installing mice with withr v2.3.0 below:

> ** byte-compile and prepare package for lazy loading
> Error: object 'local_seed' is not exported by 'namespace:withr'
> Execution halted                     
> ERROR: lazy loading failed for package 'mice'

which was easily addressed by updating withr to the latest CRAN version (v2.4.2). I note that withr is an explicit dependency listed in the DESCRIPTION but has no version requirement.

I'm sorry I haven't been able to dig up the reference to either local_seed's use in this package, nor when between 2.3.0 and 2.4.2 local_seed became an exported function. Update -- it turns out withr put it right in NEWS: -- the dependency is on withr (>=2.4.0) Please let me know if further documentation of the error is needed.

@stroberts stroberts changed the title Undocumented dependency on recent withr version Undocumented dependency withr >=2.4.0 Nov 24, 2021
stefvanbuuren added a commit that referenced this issue Nov 24, 2021
…al_seed' is not exported by 'namespace:withr'` (#445)
@stefvanbuuren
Copy link
Member

stefvanbuuren commented Nov 24, 2021

Thanks for alerting and the helpful info.

This is a new dependency. I wasn't aware that withr versions before 2.4.0 (January 2021) have this problem. Commit b85551e adds the version (>= 2.4.0) on the withr dependency.

Here's what I added to news:

@str-amg reported that the new dependency on withr package should have version 2.4.0 (published in January 2021) or higher. Version withr 2.3.0 and before may give Error: object 'local_seed' is not exported by 'namespace:withr'. Either update manually, or install the patched version mice 3.14.1 from GitHub. (#445)

Hope this solves the problem.

@stefvanbuuren
Copy link
Member

Reopening to give it higher visibility.

@stefvanbuuren stefvanbuuren reopened this Dec 9, 2021
@gerkovink gerkovink pinned this issue Dec 9, 2021
@gerkovink
Copy link
Member

@stefvanbuuren I've pinned the issue. You can close if you want - it'll remain at the top of the issues page

@hanneoberman hanneoberman unpinned this issue Jan 25, 2022
@hanneoberman hanneoberman pinned this issue Jan 25, 2022
@stefvanbuuren stefvanbuuren unpinned this issue Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants