Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace mongodb with postgres #1578

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

joeldeteves
Copy link
Contributor

@joeldeteves joeldeteves commented Jul 29, 2023

Hey guys, this one does require some testing.

I did not have time to build all containers locally and test - I was only able to verify basic deployment by running a docker-compose.

Please build and test at your discretion; we may need to script something to create the default 'postgres' database for example if MeshCentral doesn't spin up.

Other than that, all the environment variables in the start script from the Discord chat are there; I am using in prod right now in my k8s and it works with my Postgres DB which is not in the cluster, so slightly different setup (I did my best to update the docker setup accordingly).

Let me know how it looks

@codecov
Copy link

codecov bot commented Jul 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.56%. Comparing base (9118162) to head (be22f16).
Report is 465 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1578   +/-   ##
========================================
  Coverage    80.56%   80.56%           
========================================
  Files          118      118           
  Lines         7884     7884           
========================================
  Hits          6352     6352           
  Misses        1532     1532           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dinger1986
Copy link
Collaborator

this has been completed @wh1te909 could maybe close this? thanks @joeldeteves

@wh1te909
Copy link
Member

this should not be closed...docker builds still use mongo. still need a migration script for docker users for mongo to postgres then can probably merge this.

@wh1te909 wh1te909 reopened this May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants