Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Umbrella issue: Multi-language support - check and polish it for open source release #658

Open
5 of 12 tasks
quinton-hoole opened this issue Mar 21, 2019 · 8 comments
Open
5 of 12 tasks
Labels
BeforeBarcelonaKubeCon Must be resolved before release (4/30)

Comments

@quinton-hoole
Copy link
Collaborator

quinton-hoole commented Mar 21, 2019

Multi-language support - integration tests and example tutorials should cover at least 3 sufficiently different languages well (e.g. Java, Ruby, Python, and ideally an LLVM language like Rust or C++), as well as any other related languages.(JavaScript, Kotlin etc). At least some of the examples should cover client and server written in different languages, and passing user defined types between them.

See #654.

Detail to be filled in here. Individual issues and PR's to be linked to this issue.

Check list: (please add/remove as required, and check off once complete):

Same language for client and server:

  • Java
  • Ruby
  • Python
  • JavaScript
  • Rust
  • C++
  • Kotlin

Examples of different languages for client and server (please add/remove as required, and check once verified):

  • Java Client with Ruby Server
  • Java Client with JS Server
  • Java Client with Python Server
  • Ruby Client with Java Server
  • ...
@quinton-hoole quinton-hoole added the BeforeBarcelonaKubeCon Must be resolved before release (4/30) label Mar 21, 2019
@quinton-hoole quinton-hoole changed the title Multi-language support - polish it for open source release Multi-language support - check and polish it for open source release Mar 21, 2019
@prostil prostil changed the title Multi-language support - check and polish it for open source release Umbrella issue: Multi-language support - check and polish it for open source release Apr 17, 2019
@skdwriting
Copy link

Java , Ruby, JS (needs to be tested, based on my discussions) , other than these three anything more for Barcelona?
These -- we need to have good example app (not really trivial)

So, it is better to test and ensure these work first?

@quinton-hoole
Copy link
Collaborator Author

We have simple examples in this repo (in the examples/ directory). That's what I was referring to.

We have a separate repo of non-trivial demos (the repo is DCAP-Sapphire-Examples). I would suggest that we rename it '...-Demos' to avoid confusion.

@AmitRoushan
Copy link
Collaborator

AmitRoushan commented Apr 23, 2019

Current status on Ruby Example with Graal RC14:

  • Java client with Ruby MicroService is working.
  • Ruby Client with Ruby MicroService (HanksTodoApp) has issue related to passing context.
    Issue faced
     /home/roo1/development/DCAP-Sapphire/examples/hanksTodoRuby/src/main/ruby/amino/run/appexamples/hankstodo/hanks_todo_main.rb:22:in `main': The value 'DynamicObject@115c946b<Array>' cannot be passed from one context to another. The current context is 0x79ca7bea and the argument value originates from context 0x54f6b629. (ArgumentError)
        from /home/roo1/development/DCAP-Sapphire/examples/hanksTodoRuby/src/main/ruby/amino/run/appexamples/hankstodo/hanks_todo_main.rb:40:in `<main>'

Issue created #725

@maheshrajus
Copy link
Collaborator

maheshrajus commented Apr 25, 2019

Hi, PR (#736) is raised for the Javascript stub generation issue. The added code can be removed once the original issue oracle/graal#678 is fixed.

Note: the below combinations tested with the primitive data types and those are working fine. Attached test reports with PR (#736)
1)Java Client with JS Server
2)JS Client with JS Server

@AmitRoushan
Copy link
Collaborator

Multi-Lang status :

Tasks RC5 RC6 RC7 RC8 RC9
Stub Generation Working Need #736 as fix Need #736 as fix Need #736 as fix Need #736 as fix
Java client with Ruby Server Working Working Working Working Working
Ruby client with Ruby Server Working Working Working Working Not Working ( issue #725)
Java client with JS Server Working Working Working Working Working
JS client with JS Server Working Working Working Working Not Working ( same as issue #725)

Post RC9 till RC16 status is same

@AmitRoushan
Copy link
Collaborator

@quinton-hoole @skdwriting @VenuReddyHuawei @sungwook-moon
As discussed in meeting, Please give approval on falling back from Graal RC14 to RC8 once #736 get merged.

@skdwriting
Copy link

Hi Amit,
As we discussed, let us move to RC8 and support Java, Ruby and JS fully. Please create demos based on this using simple applications, as we discussed.
We will add the plan for Graal upgrade for the post Barcelona plan.

@AmitRoushan
Copy link
Collaborator

AmitRoushan commented Apr 29, 2019

@skdwriting
Added issue #738 for support RC8. PR can be raised once #736 get merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BeforeBarcelonaKubeCon Must be resolved before release (4/30)
Projects
None yet
Development

No branches or pull requests

4 participants