[MultiLang #672] Java script stub generation issue fix after migrating to GraalVM RC14 #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g to GraalVM RC14
maheshrajus
added
importance/high
maheshrajus
requested review from
prostil,
AmitRoushan,
VenuReddy2103 and
quinton-hoole
maheshrajus
changed the title
prostil
reviewed
Apr 25, 2019
examples/kvstorejs/src/main/js/amino/run/appdemo/KeyValueStore.js
Outdated
Show resolved
Hide resolved
AmitRoushan
suggested changes
Apr 25, 2019
examples/kvstorejs/src/main/js/amino/run/appdemo/KeyValueStore.js
Outdated
Show resolved
Hide resolved
examples/kvstorejs/src/main/js/amino/run/appdemo/KeyValueStoreClient.js
Outdated
Show resolved
Hide resolved
…ue fix after migrating to GraalVM RC14
examples/kvstorejs/src/main/js/amino/run/appdemo/KeyValueStore.js
Outdated
Show resolved
Hide resolved
…ue fix after migrating to GraalVM RC14
This was referenced Apr 29, 2019
…ue fix after migrating to GraalVM RC14
maheshrajus
force-pushed
the
multilangJsIssu
branch
from
8c81aa6 to
ddc4523
Compare
| //TODO: This is workaround for the issue: https://github.com/oracle/graal/issues/678. | ||
| //This will be deleted once the above issue is fixed. | ||
| //It will return all functions and instance variables in this class except constructor. | ||
| getMemberKeys() { |
There was a problem hiding this comment.
This is just a cut 'n paste of Student.getMemberKeys(). The only difference is the type of obj.
Please rather create a library function that takes obj as a parameter, and have them all call that.
There was a problem hiding this comment.
@quinton-hoole : As per your comment, The common code we can put as Util function and call it and get the output by passing the object.
It involves some complexity as per my analysis. There is no direct way to import the Util.js file into Student.js/KeyValueStore.js files as these are plain JS files.
Currently, we are exploring it and we can handle it in the future.
There was a problem hiding this comment.
Ok, sure.. I will open one issue for this.
…ation issue fix after migrating to GraalVM RC14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<This is subtask for issue #658>
Upgrade from RC5 to RC14 was successful except one - kvstorejs.
Please refer to the below comment for detail.
(Related merged PR #664)
As per quinton's suggestion:
Build Report:
Stub Geneation:
Java Client:
JS Client:
