Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update minio #297

Merged
merged 9 commits into from
Oct 22, 2022
Merged

Update minio #297

merged 9 commits into from
Oct 22, 2022

Conversation

BuJo
Copy link
Collaborator

@BuJo BuJo commented Aug 2, 2022

This also touches the minio admin user/password as minio complains about deprecated access key/secret key env vars.

@BuJo
Copy link
Collaborator Author

BuJo commented Aug 3, 2022

Allright, I think I've found all of them.
I implemented it backwards compatible, but with a focus on not breaking old setups but adhering to the new naming of minio.

I've found https://www.terraform.io/plugin/sdkv2/best-practices/deprecations#renaming-a-required-attribute which we could use to also rename the provider arguments.
It looks slightly more complicated, however we should probably do something along those lines to keep us aligned to the naming scheme of minio..
We could do that now or a little later, but we should probably do that within the same release to not confuse people. What do you think?

@felladrin
Copy link
Collaborator

felladrin commented Aug 3, 2022 •
edited
Loading

I think we can do a release now (which would be v1.5.3), before merging this PR.

After releasing it, we'd then merge this PR and create another one for the renaming. After merging them, we'd release v1.6.0.

Can we do like that?

If so, you can do the release this time, @BuJo! All we need to do is to create and push a tag "v1.5.3", so GoReleaser will build and publish a release on this repository (which will be automatically pulled by Terraform Plugins website through web hooks).

@BuJo
Copy link
Collaborator Author

BuJo commented Aug 3, 2022

Awesome! Yeah, let's make a release before handling this one. I'll give it a try, thank you @felladrin !

BuJo added 6 commits August 9, 2022 11:35
@BuJo
Update minio
298065b
@BuJo
test, revise pre check to be more strict
d72211a 
* needs all environment variables to be checked
@BuJo
Use MINIO_ROOT_USER/MINIO_ROOT_PASSWORD instead of deprecated env vars
afdfca8 
* MINIO_ACCESS_KEY and MINIO_SECRET_KEY are deprecated since
  version RELEASE.2021-04-22T15-44-28Z.
* Note that the Terraform Provider will still accept the old variables.
@BuJo
provider, use user/password instead of root user/pwd
7d86431 
* Makes meaning more clear
* see minio/minio#11185
@BuJo
Deprecate use of minio_access_key/minio_secret_key
00e326f 
* Use minio_user/minio_password to follow minio
* See minio/minio#11185
@BuJo
tests, fixup use of temporary MINIO_ROOT_USER variable
0550839
@BuJo BuJo marked this pull request as draft August 9, 2022 09:37
@felladrin felladrin mentioned this pull request Oct 22, 2022
Closed
@felladrin felladrin marked this pull request as ready for review October 22, 2022 21:19
@felladrin
Copy link
Collaborator

@BuJo, I've updated the PR, and I believe it's ready. Would you squash and merge it before releasing v1.8.0?

@BuJo
Copy link
Collaborator Author

BuJo commented Oct 22, 2022

Thanks @felladrin ! Let's just do it, it shouldn't lead to too much problems. Thank you!

@BuJo BuJo merged commit 243676c into master Oct 22, 2022
@BuJo BuJo deleted the update_minio branch October 22, 2022 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felladrin felladrin felladrin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BuJo @felladrin