Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minio_s3_bucket_versioning resource #368

Merged
merged 1 commit into from
Oct 22, 2022

Conversation

pjsier
Copy link
Collaborator

@pjsier pjsier commented Oct 21, 2022

Adds minio_s3_bucket_versioning to add support for S3 versioning. I added a separate resource rather than a versioning parameter because the parameter approach has been deprecated on the aws_s3_bucket resource in favor of adding a separate resource.

Minio accepts more configuration fields for versioning than Status (more details in the BucketVersioningConfiguration struct in the client), but I wanted to just start with status for now since the others are optional.

Let me know if I should make any changes, thanks!

Reference

@pjsier pjsier force-pushed the bucket-versioning-77 branch from 24f5d1b to 59d9358 Compare October 21, 2022 22:48
Copy link
Collaborator

@BuJo BuJo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good, also good catch on how the aws provider does things. Bundling extra functionality in extra Resorces also payed off with policies (a resource instead of a policy field which generated problems).

@BuJo
Copy link
Collaborator

BuJo commented Oct 22, 2022

A new feature, let's increase the minor version field on the next release. Thank you @pjsier !

@BuJo BuJo merged commit 4ddb118 into aminueza:master Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Versioning Support
2 participants