Fix service account login #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Simplifies code, moves recreation code into the terraform infrastructure
* The access key was not filled correctly, the target user was used to check the service account. * Also simplifies changes for secret and status
* The target user must exist to create a correct test case, use the `minio` user as target, as it has enough rights.
* Service accounts cannot log in to the UI, it thus needs a different way to check the correct password.
felladrin
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes problems unearthed by changes in #364
Changes:
ForceNewon target user changes. This just simplifies the code.miniouser as target user, which also removes the oddity of using a non-existent target user in the tests.