Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix importing minio_iam_group #390

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

pjsier
Copy link
Collaborator

@pjsier pjsier commented Nov 14, 2022

Changes

  • Updates the read operation for minio_iam_group to use d.Id() instead of referencing the group config so that importing works
  • Updates the associated test to check whether or not import works by adding a step with ImportState

While updating this I noticed that the behavior of using a hidden group_name field in addition to name as well as only reading group_name in minioReadGroup seemed a bit odd. For now I just ignored the fields that aren't read to match the pattern from other test files. Would it make sense to refactor that in the future or am I missing something in the implementation?

Closing issues

Copy link
Collaborator

@felladrin felladrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it!
I've tested it, and it's working as described, solving the issue mentioned above.

Would it make sense to refactor that in the future or am I missing something in the implementation?

Hmm, I'm unable to answer it. But I'd vote for refactoring it.

@felladrin felladrin merged commit bd98cda into aminueza:master Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

terraform import minio_iam_group.test doesn't work
2 participants