Add minio_s3_bucket_notification resource #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjsier
force-pushed
the
feat-minio-s3-bucket-notification-54
branch
from
b836ab4 to
92f9dd7
Compare
felladrin
approved these changes
Dec 6, 2022
There was a problem hiding this comment.
Thanks for this PR, @pjsier!
Tested and approved!
And I'm glad you asked about becoming a maintainer! We'd love an extra hand to maintain the project. I'll ask @aminueza to invite you as Collaborator.
Once you're a collaborator, you'll also be able to push tags, besides reviewing/merging PRs. Pushing a tag automatically generates a new release here. And then it automatically becomes available at https://registry.terraform.io/providers/aminueza/minio.
You can start pushing a new tag (v1.10.0, due to this new feature) as soon as this PR lands into main branch :)
|
Thanks @felladrin and @aminueza for the add! Just updated the tag, let me know if everything looks right but it seems like the build went through normally |
coolguy1771
referenced
this pull request
in coolguy1771/home-ops
Dec 9, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [minio](https://registry.terraform.io/providers/aminueza/minio) ([source](https://togithub.com/aminueza/terraform-provider-minio)) | required_provider | minor | `1.9.1` -> `1.10.0` | --- ### Release Notes <details> <summary>aminueza/terraform-provider-minio</summary> ### [`v1.10.0`](https://togithub.com/aminueza/terraform-provider-minio/releases/tag/v1.10.0) [Compare Source](https://togithub.com/aminueza/terraform-provider-minio/compare/v1.9.1...v1.10.0) #### What's Changed - Update module github.com/aws/aws-sdk-go to v1.44.142 by [@​renovate](https://togithub.com/renovate) in [https://github.com/aminueza/terraform-provider-minio/pull/391](https://togithub.com/aminueza/terraform-provider-minio/pull/391) - Update module github.com/minio/minio-go/v7 to v7.0.44 by [@​renovate](https://togithub.com/renovate) in [https://github.com/aminueza/terraform-provider-minio/pull/392](https://togithub.com/aminueza/terraform-provider-minio/pull/392) - Update module github.com/aws/aws-sdk-go to v1.44.145 by [@​renovate](https://togithub.com/renovate) in [https://github.com/aminueza/terraform-provider-minio/pull/393](https://togithub.com/aminueza/terraform-provider-minio/pull/393) - Update module github.com/aws/aws-sdk-go to v1.44.152 by [@​renovate](https://togithub.com/renovate) in [https://github.com/aminueza/terraform-provider-minio/pull/395](https://togithub.com/aminueza/terraform-provider-minio/pull/395) - Update module github.com/minio/minio-go/v7 to v7.0.45 by [@​renovate](https://togithub.com/renovate) in [https://github.com/aminueza/terraform-provider-minio/pull/394](https://togithub.com/aminueza/terraform-provider-minio/pull/394) - Add minio_s3\_bucket_notification resource by [@​pjsier](https://togithub.com/pjsier) in [https://github.com/aminueza/terraform-provider-minio/pull/396](https://togithub.com/aminueza/terraform-provider-minio/pull/396) **Full Changelog**: aminueza/terraform-provider-minio@v1.9.1...v1.10.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC41Mi4wIiwidXBkYXRlZEluVmVyIjoiMzQuNTIuMCJ9--> Co-authored-by: lumiere-bot <98047013+lumiere-bot[bot]@users.noreply.github.com>
|
Perfect! 🎉 Welcome aboard! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
minio_s3_bucket_notificationto add support for bucket notifications. Even though the Go API supports Lamda and Topic/SNS targets, when I tried to test with other values I got an error from the server that only queue/SQS events are currently supported. I based the implementation on the AWS provider though, so if support was later added it would be straightforward to add support forlambda_functionandtopicblocks.I had to update the
docker-compose.ymlconfiguration based on the webhook event documentation because Minio requires environment variables to be set to configure a target.I also wanted to check if you're looking for any other maintainers, I'd be interested in helping to review PRs if it would be helpful.
Reference