Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Tags in minio_ilm_policy resource #417

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Add support for Tags in minio_ilm_policy resource #417

merged 1 commit into from
Jan 30, 2023

Conversation

pablo-ruth
Copy link
Contributor

@pablo-ruth pablo-ruth commented Jan 23, 2023 •
edited
Loading

Add support for Tags in minio_ilm_policy resource

This PR implements the following changes:

  • Add a "tags" argument to the "rule" block, to set the tags of the rule filter
  • Following the S3 docs, this PR implements the different XML formatting when using "filter" argument only (prefix), and when using "tags" with it
  • Add acceptance tests for these two cases

Reference

pjsier
pjsier approved these changes Jan 26, 2023
View reviewed changes
Copy link
Collaborator

@pjsier pjsier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This looks great and the tests are passing. I'll approve and leave open for a bit in case anyone else wants to take a look

@pablo-ruth
Copy link
Contributor Author

Great, thanks for the review and approval! I'll wait for the merge :)

@pjsier pjsier merged commit 7603594 into aminueza:master Jan 30, 2023
@pablo-ruth pablo-ruth deleted the FilterTags branch January 30, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjsier pjsier pjsier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pablo-ruth @pjsier