Add support for LDAP user and group in policy attachments

[acolombier]

This PR implements the following changes:

• Add support for LDAP DN as group_name in the resource minio_iam_group_policy_attachment
• Add support for LDAP DN as user_name in the resource minio_iam_user_policy_attachment

Reference

• Resolves: Add support for LDAP users and groups on policy attachment resources #445

Closing issues

• Closes: Add support for LDAP users and groups on policy attachment resources #445

Note

When running tfplugindocs (v0.14.1), it did update couple of syntax unrelated to this change; it now seems to make the difference between optional arguments and read-only arguments.

Currently, I have only pushed those that are relevant to this PR (doc related to the proposed change), but let me know if you would like me to push the other updates in a new PR.

[BuJo]

I had a look at the changes, the only thing that I found a little odd is that minio can't provide information about LDAP users/groups.

[acolombier]

I had a look at the changes, the only thing that I found a little odd is that minio can't provide information about LDAP users/groups.

Minio can actually provide information about LDAP users/groups that it has a configuration for. Removing the section that perform LDAP user/group assert removes the ability for the provider to perform drift detection/reconciliation.

[acolombier]

@BuJo after further digging, it looks like only GetUserInfo needs the special error handling in case it is a LDAP user, so I have remove the group one. Also added specific catch for LDAP user, so it wouldn't obfuscate any errors returned by madmin.AdminClient.GetUserInfo

Tested locally with a mix set of static users and group, as well as LDAP user and group too. Tested happy path and reconciliation.

I feel like the user custom logic should definitely be covered with unit tests, but AFAIS, this would require some refactoring to support DI in order to allow madmin.AdminClient.GetUserInfo mocking.

IMHO, this refactoring should neither happen in this PR as it is out of scope with the task at hand, and unfortunately I'm unsure I currently have the time to put that effort in too. I have added couple of debug output so if this ever regress in future versions, there should at least be some debugging starting point.

Hopefully this is acceptable.

[BuJo]

Allright, I think it's good to go. While I'd prefer some tests for feeling more comfortable, I'm quite sure it won't break a current usecase.
Thank you for your work!

[zeqk]

Hi! Thank you very much for work in this feature, I need this.
When will this change be released?
https://registry.terraform.io/providers/aminueza/minio/latest
https://github.com/aminueza/terraform-provider-minio/releases/

[felladrin]

Hi! Thank you very much for work in this feature, I need this. When will this change be released?

✅ Published in release 1.14.0.