Add support for object locking in minio_s3_bucket resource. #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @Eilyre! Thanks and congrats for your first contribution! A very welcome addition! |
|
Hello, thank you for the warm welcome! I completely forgot the tests, I'll do my best to fix them, but it'll take a bit of time, as currently the tests look more complicated than the application code - I'm fairly new to this. |
|
I think I have the tests fixed now. There's still one test that fails locally - resource_minio_s3_bucket_notification_test.go:34 (TestS3BucketNotification_queue), but it also fails locally on the master branch without my changes. |
felladrin
approved these changes
May 6, 2023
This was referenced May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the option to enable object locking with
minio_s3_bucketresource type. There's a new optionobject_locking, that can be specified for these resources.Default behavior did not change, and object locking defaults to false.
Reference