Fix null expiration date handling #545

pjsier · 2023-11-07T12:34:06Z

Fix null expiration date handling

Fixes an issue where null expiration dates were getting set in the state as 0001-01-01 instead of nil, causing an update for every plan or apply.

Reference

Resolves: Lifecycle rule with noncurrent_version_expiration_days causes a update every plan/apply in 2.0.0 #543

Closing issues

Closes: Lifecycle rule with noncurrent_version_expiration_days causes a update every plan/apply in 2.0.0 #543

felladrin

Self-reminder: once it's merged we'll need to cherry-pick it from main to v1 branch, as it should be affected by the same issue.

(cherry picked from commit f3d4298)

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [minio](https://registry.terraform.io/providers/aminueza/minio) ([source](https://github.com/aminueza/terraform-provider-minio)) | required_provider | minor | `~> 1.18.0` -> `~> 1.20.0` | --- > ⚠ **Warning** > > Some dependencies could not be looked up. Check the warning logs for more information. --- ### Release Notes <details> <summary>aminueza/terraform-provider-minio (minio)</summary> ### [`v1.20.1`](https://github.com/aminueza/terraform-provider-minio/releases/tag/v1.20.1) [Compare Source](aminueza/terraform-provider-minio@v1.20.0...v1.20.1) #### What's Changed - Fix null expiration date handling by [@pjsier](https://github.com/pjsier) in aminueza/terraform-provider-minio#545 - Update terraform version to 1.5.7 in GitHub Action by [@felladrin](https://github.com/felladrin) in aminueza/terraform-provider-minio#540 **Full Changelog**: aminueza/terraform-provider-minio@v1.20.0...v1.20.1 > **Note** > [v1](https://github.com/aminueza/terraform-provider-minio/tree/v1) of the provider is now under maintenance mode. If you can, it's advised to upgrade to `v2`. ### [`v1.20.0`](https://github.com/aminueza/terraform-provider-minio/releases/tag/v1.20.0) [Compare Source](aminueza/terraform-provider-minio@v1.19.0...v1.20.0) #### What's Changed - Update module github.com/aws/aws-sdk-go to v1.45.6 by [@renovate](https://github.com/renovate) in aminueza/terraform-provider-minio#515 - Update crazy-max/ghaction-import-gpg action to v6 by [@renovate](https://github.com/renovate) in aminueza/terraform-provider-minio#516 - Handle empty service account policy by [@ArataEM](https://github.com/ArataEM) in aminueza/terraform-provider-minio#518 - Go 1.20 by [@BuJo](https://github.com/BuJo) in aminueza/terraform-provider-minio#519 - Destroy object versions on bucket force_destroy by [@pjsier](https://github.com/pjsier) in aminueza/terraform-provider-minio#524 - Update goreleaser-action to v5 and add permission for the workflow to attach binaries to GitHub Releases by [@felladrin](https://github.com/felladrin) in aminueza/terraform-provider-minio#521 - Add Noncurrent Version expiration to ilm policy by [@ndejesus](https://github.com/ndejesus) in aminueza/terraform-provider-minio#526 - Bump golang.org/x/net from 0.15.0 to 0.17.0 by [@dependabot](https://github.com/dependabot) in aminueza/terraform-provider-minio#530 - Add service account values to read and import by [@pjsier](https://github.com/pjsier) in aminueza/terraform-provider-minio#525 - feat: recreate user if not found anymore by [@tobikris](https://github.com/tobikris) in aminueza/terraform-provider-minio#534 - Bump google.golang.org/grpc from 1.58.0 to 1.58.3 by [@dependabot](https://github.com/dependabot) in aminueza/terraform-provider-minio#535 #### New Contributors - [@ndejesus](https://github.com/ndejesus) made their first contribution in aminueza/terraform-provider-minio#526 **Full Changelog**: aminueza/terraform-provider-minio@v1.18.0...v1.20.0 > **Note** > This release replaces v1.18.1 and v1.18.2, which are unavailable on https://registry.terraform.io/providers/aminueza/minio as they were built with an outdated GPG key. It also replaces v1.18.3 and v1.19.0, which couldn't be installed due the issue [#531](aminueza/terraform-provider-minio#531). ### [`v1.19.0`](https://github.com/aminueza/terraform-provider-minio/releases/tag/v1.19.0) [Compare Source](aminueza/terraform-provider-minio@v1.18.3...v1.19.0) Changes on this Release: - Update crazy-max/ghaction-import-gpg action to v6 ([#516](aminueza/terraform-provider-minio#516)) - Handle empty service account policy ([#518](aminueza/terraform-provider-minio#518)) - Update repository URL ([#520](aminueza/terraform-provider-minio#520)) - Destroy object versions on bucket force_destroy ([#524](aminueza/terraform-provider-minio#524)) - Add Noncurrent Version expiration to ilm policy ([#526](aminueza/terraform-provider-minio#526)) **Full Changelog**: aminueza/terraform-provider-minio@v1.18.0...v1.19.0 > **Note** > This release replaces v1.18.1 and v1.18.2, which are unavailable on https://registry.terraform.io/providers/aminueza/minio as they were built with an outdated GPG key. It also replaces v1.18.3, which couldn't be installed due the issue [#531](aminueza/terraform-provider-minio#531). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.eevans.me/shosti/eevans-infra/pulls/10 Co-authored-by: Renovate Bot <renovate@eevans.co> Co-committed-by: Renovate Bot <renovate@eevans.co>

Fix null expiration date handling

119f767

pjsier mentioned this pull request Nov 7, 2023

Lifecycle rule with noncurrent_version_expiration_days causes a update every plan/apply in 2.0.0 #543

Closed

felladrin approved these changes Nov 7, 2023

View reviewed changes

felladrin merged commit f3d4298 into aminueza:main Nov 7, 2023
2 checks passed

felladrin pushed a commit that referenced this pull request Nov 7, 2023

Fix null expiration date handling (#545)

d1e4ed8

(cherry picked from commit f3d4298)

felladrin mentioned this pull request Nov 7, 2023

Preparation for Release v1.20.1 #546

Merged

felladrin pushed a commit that referenced this pull request Nov 8, 2023

Fix null expiration date handling (#545)

e44d5e6

(cherry picked from commit f3d4298)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix null expiration date handling #545

Fix null expiration date handling #545

pjsier commented Nov 7, 2023

felladrin left a comment

Fix null expiration date handling #545

Fix null expiration date handling #545

Conversation

pjsier commented Nov 7, 2023

Fix null expiration date handling

Reference

Closing issues

felladrin left a comment

Choose a reason for hiding this comment