-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resource_minio_s3_object 'source' support #555
Conversation
Sorry for the delay in looking at this! It would be great to add some test cases here for CI if you have a chance |
@pjsier Is there some sort of 'best practice' for testing opening/reading files in Go? I've only dabbled a bit in the language so far and I don't know much about writing unit tests in it. |
@fhemberger I'm not sure on overall best practices, but I think we could leverage a similar pattern to the AWS provider adding a method to create tempfiles that can then be used later in the test |
@pjsier I'm still having trouble setting up the unit tests, however, I'd really appreciate it if the fix could land anyways, as:
So even without test cases, that's already an improvement over the current state. |
/ping @pjsier @felladrin |
Thanks @fhemberger! It's being released on v2.1.0. |
@felladrin Thank you! |
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [minio](https://registry.terraform.io/providers/aminueza/minio) ([source](https://togithub.com/aminueza/terraform-provider-minio)) | required_provider | major | `1.20.1` -> `2.1.0` | --- ### Release Notes <details> <summary>aminueza/terraform-provider-minio (minio)</summary> ### [`v2.1.0`](https://togithub.com/aminueza/terraform-provider-minio/releases/tag/v2.1.0) [Compare Source](https://togithub.com/aminueza/terraform-provider-minio/compare/v2.0.1...v2.1.0) #### What's Changed - Fixed group policy assign parameter typo by [@​danielhass](https://togithub.com/danielhass) in [https://github.com/aminueza/terraform-provider-minio/pull/553](https://togithub.com/aminueza/terraform-provider-minio/pull/553) - Document `DeleteMarker` expiry in ilm policy by [@​michaelruigrok](https://togithub.com/michaelruigrok) in [https://github.com/aminueza/terraform-provider-minio/pull/558](https://togithub.com/aminueza/terraform-provider-minio/pull/558) - Add resource_minio_s3\_object 'source' support by [@​fhemberger](https://togithub.com/fhemberger) in [https://github.com/aminueza/terraform-provider-minio/pull/555](https://togithub.com/aminueza/terraform-provider-minio/pull/555) #### New Contributors - [@​danielhass](https://togithub.com/danielhass) made their first contribution in [https://github.com/aminueza/terraform-provider-minio/pull/553](https://togithub.com/aminueza/terraform-provider-minio/pull/553) - [@​michaelruigrok](https://togithub.com/michaelruigrok) made their first contribution in [https://github.com/aminueza/terraform-provider-minio/pull/558](https://togithub.com/aminueza/terraform-provider-minio/pull/558) - [@​fhemberger](https://togithub.com/fhemberger) made their first contribution in [https://github.com/aminueza/terraform-provider-minio/pull/555](https://togithub.com/aminueza/terraform-provider-minio/pull/555) **Full Changelog**: aminueza/terraform-provider-minio@v2.0.1...v2.1.0 ### [`v2.0.1`](https://togithub.com/aminueza/terraform-provider-minio/releases/tag/v2.0.1) [Compare Source](https://togithub.com/aminueza/terraform-provider-minio/compare/v2.0.0...v2.0.1) #### What's Changed - Fix null expiration date handling by [@​pjsier](https://togithub.com/pjsier) in [https://github.com/aminueza/terraform-provider-minio/pull/545](https://togithub.com/aminueza/terraform-provider-minio/pull/545) - Update terraform version to 1.5.7 in GitHub Action by [@​felladrin](https://togithub.com/felladrin) in [https://github.com/aminueza/terraform-provider-minio/pull/540](https://togithub.com/aminueza/terraform-provider-minio/pull/540) **Full Changelog**: aminueza/terraform-provider-minio@v2.0.0...v2.0.1 ### [`v2.0.0`](https://togithub.com/aminueza/terraform-provider-minio/releases/tag/v2.0.0) [Compare Source](https://togithub.com/aminueza/terraform-provider-minio/compare/v1.20.1...v2.0.0) #### What's Changed - Update madmin-go to version 3 by [@​acolombier](https://togithub.com/acolombier) in [https://github.com/aminueza/terraform-provider-minio/pull/514](https://togithub.com/aminueza/terraform-provider-minio/pull/514) - Handle empty service account policy by [@​ArataEM](https://togithub.com/ArataEM) in [https://github.com/aminueza/terraform-provider-minio/pull/518](https://togithub.com/aminueza/terraform-provider-minio/pull/518) - Go 1.20 by [@​BuJo](https://togithub.com/BuJo) in [https://github.com/aminueza/terraform-provider-minio/pull/519](https://togithub.com/aminueza/terraform-provider-minio/pull/519) - Destroy object versions on bucket force_destroy by [@​pjsier](https://togithub.com/pjsier) in [https://github.com/aminueza/terraform-provider-minio/pull/524](https://togithub.com/aminueza/terraform-provider-minio/pull/524) - Update goreleaser-action to v5 and add permission for the workflow to attach binaries to GitHub Releases by [@​felladrin](https://togithub.com/felladrin) in [https://github.com/aminueza/terraform-provider-minio/pull/521](https://togithub.com/aminueza/terraform-provider-minio/pull/521) - Add Noncurrent Version expiration to ilm policy by [@​ndejesus](https://togithub.com/ndejesus) in [https://github.com/aminueza/terraform-provider-minio/pull/526](https://togithub.com/aminueza/terraform-provider-minio/pull/526) - Add service account values to read and import by [@​pjsier](https://togithub.com/pjsier) in [https://github.com/aminueza/terraform-provider-minio/pull/525](https://togithub.com/aminueza/terraform-provider-minio/pull/525) - feat: add minio_s3\_bucket_replication resource by [@​acolombier](https://togithub.com/acolombier) in [https://github.com/aminueza/terraform-provider-minio/pull/528](https://togithub.com/aminueza/terraform-provider-minio/pull/528) - feat: recreate user if not found anymore by [@​tobikris](https://togithub.com/tobikris) in [https://github.com/aminueza/terraform-provider-minio/pull/534](https://togithub.com/aminueza/terraform-provider-minio/pull/534) - Bump google.golang.org/grpc from 1.58.0 to 1.58.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/aminueza/terraform-provider-minio/pull/535](https://togithub.com/aminueza/terraform-provider-minio/pull/535) - Change terraform-provider-minio license to AGPL-3.0 and append `/v2` to the module name by [@​BuJo](https://togithub.com/BuJo) in [https://github.com/aminueza/terraform-provider-minio/pull/522](https://togithub.com/aminueza/terraform-provider-minio/pull/522) #### Breaking Change: About the major version update We've updated `madmin-go` to `v3` so we can use the new features from the SDK, like the [bucket replication](https://togithub.com/aminueza/terraform-provider-minio/pull/528). As a consequence of this, we had to change our License to AGPL-3.0 to comply with `madmin-go`, [which has been using AGPL-3.0 since its v2 release](https://togithub.com/minio/madmin-go/pull/154). For those who can't upgrade to **terraform-provider-minio v2** due to license incompatibilities, we recommend you keep using the **v1** until you feel you need some of the new features. To don't let anyone behind, we've created a [v1](https://togithub.com/aminueza/terraform-provider-minio/tree/v1) branch, which is now protected and will live along with the [main](https://togithub.com/aminueza/terraform-provider-minio/tree/main). So if users of `v1` want to push features/fixes, they can create pull requests targeting that branch, and as soon as it's merged, we release a new update for the `v1.x`. For those importing this package in their software and want to upgrade, here's the command to upgrade: ```bash go get github.com/aminueza/terraform-provider-minio/v2@​v2.0.0 ``` **Full Changelog**: aminueza/terraform-provider-minio@v1.18.0...v2.0.0 > **Note** > [v1](https://togithub.com/aminueza/terraform-provider-minio/tree/v1) branch diverged from [main](https://togithub.com/aminueza/terraform-provider-minio/tree/main) at after the [release v1.18.0](https://togithub.com/aminueza/terraform-provider-minio/releases/tag/v1.18.0). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMzUuNSIsInVwZGF0ZWRJblZlciI6IjM3LjIzNS42IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: kireque-bot[bot] <143391978+kireque-bot[bot]@users.noreply.github.com>
Add resource_minio_s3_object 'source' support for PutObject
Only 'content' and 'content_base64' have been implemented sofar, this PR adds 'source' support for resource_minio_s3_object, derived from https://github.com/hashicorp/terraform-provider-aws/blob/main/internal/service/s3/bucket_object.go#L388-L405
Reference
Closing issues