Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove force_destroy check from user update to prevent unintended deletions #591

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

felladrin
Copy link
Collaborator

@felladrin felladrin commented Nov 9, 2024

The change ensures that:

  • force_destroy only takes effect during actual deletion operations

  • Updates to the user resource won't trigger unexpected deletions

  • The behavior matches standard Terraform patterns where force_destroy is only considered during resource destruction

This fixes the problem mentioned here while maintaining the intended functionality of force_destroy for actual deletion operations.

@felladrin felladrin merged commit d1a9ab6 into main Nov 9, 2024
2 checks passed
@felladrin felladrin deleted the remove-force-destroy-from-iam-user branch November 9, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants