decaffeinate #2
Merged
decaffeinate #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decaffeinate . --use-js-modules --loose
decaffeinate . --modernize-js
Get-ChildItem *.coffee -Recurse | foreach { Remove-Item -Path $_.FullName }
Now that we have babel we can use optional chaining
Make formatting like the original code
Make the formatting like the original code
|
Already upstreamed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready
Description of the Change
Decaffeination: rewrites the codebase in JavaScript
Rollup: bundle the package using rollupMoved to separate PRHow to review?
Tests are untouched to show full functionality and backward compatibility. ✔️
If you wanna check commit history:
Remove guard: using if checks instead of optional chaining in CoffeeScript=-> now we use optional chaining using babelif (variable)instead ofif (variable != null)whenever it is safeAlternate Designs
Benefits
- Faster loading time because of using JavaScript and Rollup.Possible Drawbacks
Optional chaining isn't as compact as CoffeeScript in JavaScript. I rewrote them using=> Now use optional chaining using babelifchecks. By switching to TypeScript/or a new Babel version we can write them more compact.Applicable Issues
Updates the package to make it ready for atom/atom#18282
Closes the old PR: atom#215