Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status + Add version + Update data example + Add type and rule validation #27

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

angelofan
Copy link

@angelofan angelofan commented Dec 30, 2023

For #13

Added status properties to support various custom filtering.

For #14

Added version.

Other

  • Updated content of data examples in readme file.
  • Updated emoji.json

Edit:

For #27 (comment)

Add type and rule validation before writing the full data to the emoji.json.

@angelofan angelofan changed the title add status + Update data example Add status + Add version + Update data example Dec 30, 2023
@amio
Copy link
Owner

amio commented Jan 4, 2024

@angelofan Great work!

I guess we would need a test to verify that the generated json fulfills our type definition, just in case the regex fails someday.

@angelofan
Copy link
Author

@angelofan Great work!

I guess we would need a test to verify that the generated json fulfills our type definition, just in case the regex fails someday.

Good idea. I will try adding type validation before writing the final array to the file.

@angelofan angelofan changed the title Add status + Add version + Update data example Add status + Add version + Update data example + Add type and rule validation Jan 4, 2024
@angelofan
Copy link
Author

@amio I added type and rule validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants