More portable Export download tasks and imports, support curl #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amir1376
requested changes
Mar 9, 2025
| fun generateCurlCommands(credentialsList: List<DownloadCredentials>): List<String> | ||
| } | ||
|
|
||
| object DownloadCredentialsFromStringExtractor : DownloadCredentialsFromCurl<String> { |
There was a problem hiding this comment.
We already have another class with this name which extracts simple links.
it should be something like this instead
object DownloadCredentialsFromCurl: DownloadCredentialExtractor<String> | import com.abdownloadmanager.shared.utils.extractors.Extractor | ||
|
|
||
|
|
||
| interface DownloadCredentialsFromCurl<T>: Extractor<T, List<DownloadCredentials>> { |
There was a problem hiding this comment.
we already had this interface (DownloadCredentialExtractor) so remove this.
amir1376
reviewed
Mar 9, 2025
Comment on lines
225
to
229
| ClipboardUtil.copy( | ||
| selections.value | ||
| .map { it.downloadLink } | ||
| .joinToString(System.lineSeparator()) | ||
| ) | ||
| val credentialsList = selections.value | ||
| .mapNotNull { downloadSystem.getDownloadItemById(it.id) } | ||
| .map { DownloadCredentials.from(it) } | ||
| ClipboardUtil.copy(DownloadCredentialsFromStringExtractor.generateCurlCommands(credentialsList).joinToString("\n")) |
There was a problem hiding this comment.
Please keep the previous logic. which simply copies the download link.
I will add another button to "Export download as Curl" instead later
amir1376
requested changes
Mar 9, 2025
There was a problem hiding this comment.
everything looks good thank you
the only think is that we use crowdin for translation
in PR just add english translation. other languages will be featched from Crowdin and rhere is no need to create them here as they make this synchronization with crowdin harder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.