Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added function to add new line. #53

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nxiss7
Copy link

@nxiss7 nxiss7 commented Mar 8, 2020

I think adding new lines is a common task, it's a must-have feature for me.

@amiremohamadi
Copy link
Owner

Thank You for the PR!

I think it would be better to define new_line as a constant.
refer to python-docx library, we can define an enum/class (e.g BREAK) that has a value called LINE. So user can add a new line break like this:

p.add_run(duckx::BREAK::LINE);

Feel free to send PRs :)

@nxiss7
Copy link
Author

nxiss7 commented Mar 9, 2020

Ok, will take look and update code.
:D

@nxiss7
Copy link
Author

nxiss7 commented Mar 27, 2020

After a few busy weeks I could finally refactor the code.
I also added support for columns and tab character too.

@SimantoR
Copy link

SimantoR commented Jan 1, 2023

This PR seems ready to be merged in. Any tests to add or verify for this?

@amiremohamadi
Copy link
Owner

This PR seems ready to be merged in. Any tests to add or verify for this?

Hi @SimantoR, it seems ready but after completing #81 this will be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants