Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libzip buffer #74

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Libzip buffer #74

wants to merge 3 commits into from

Conversation

vaguue
Copy link

@vaguue vaguue commented Dec 19, 2021

DuckX is using miniz library, which is unable to parse zip archive in-memory (from char*), hence I rewrote some pieces of code using libzip, and extended functionality of save method with capability to save to another files. The code is quite raw and slightly tested, but I decided to open pull request now in order to discuss upcoming changes. The most unsolved issue is an addition of libzip library using cmake (I don't know how to do it).

@vaguue
Copy link
Author

vaguue commented Dec 19, 2021

Maybe it's a good idea to add a capability to save a data in an input buffer?

@amiremohamadi
Copy link
Owner

thanks for Your PR. DuckX used to use libzip, but the reason for switching to kuba's zip library was keeping DuckX as minimal as possible. libzip is excellent but that's huge, we don't need the whole functionality also. at this point, I'm thinking of hacking kuba's zip library or implementing a part of miniz inside DuckX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants