Skip to content

Commit 48afdac

Browse files
liyuqianAmir Hardon
authored andcommitted
Remove LayerBuilder and DefaultLayerBuilder (flutter#6256)
This essentially reverts flutter#4197 as no one is (or soon will be) implementing an alternative LayerBuilder. Let's just put everything in SceneBuilder to reduce the YAGNI (you aren't gonna need it) smell. This will also make retained rendering API changes much easier.
1 parent 4039eb0 commit 48afdac

File tree

8 files changed

+180
-547
lines changed

8 files changed

+180
-547
lines changed

ci/licenses_golden/licenses_flutter

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -251,10 +251,6 @@ FILE: ../../../flutter/assets/asset_manager.h
251251
FILE: ../../../flutter/assets/asset_resolver.h
252252
FILE: ../../../flutter/common/task_runners.cc
253253
FILE: ../../../flutter/common/task_runners.h
254-
FILE: ../../../flutter/flow/layers/default_layer_builder.cc
255-
FILE: ../../../flutter/flow/layers/default_layer_builder.h
256-
FILE: ../../../flutter/flow/layers/layer_builder.cc
257-
FILE: ../../../flutter/flow/layers/layer_builder.h
258254
FILE: ../../../flutter/flow/skia_gpu_object.cc
259255
FILE: ../../../flutter/flow/skia_gpu_object.h
260256
FILE: ../../../flutter/runtime/dart_isolate.cc

flow/BUILD.gn

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,8 @@ source_set("flow") {
2222
"layers/color_filter_layer.h",
2323
"layers/container_layer.cc",
2424
"layers/container_layer.h",
25-
"layers/default_layer_builder.cc",
26-
"layers/default_layer_builder.h",
2725
"layers/layer.cc",
2826
"layers/layer.h",
29-
"layers/layer_builder.cc",
30-
"layers/layer_builder.h",
3127
"layers/layer_tree.cc",
3228
"layers/layer_tree.h",
3329
"layers/opacity_layer.cc",

flow/layers/default_layer_builder.cc

Lines changed: 0 additions & 235 deletions
This file was deleted.

flow/layers/default_layer_builder.h

Lines changed: 0 additions & 104 deletions
This file was deleted.

0 commit comments

Comments
 (0)