This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Move layer tree construction into flow::LayerBuilder so alternate builders can be plugged in. #4197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lders can be plugged in.
| m_currentLayer->Add(std::move(layer)); | ||
| m_currentLayer = newLayer; | ||
| layer_builder_.PushPhysicalModel( | ||
| rrect.sk_rrect, // |
Member
There was a problem hiding this comment.
Add text here or remove these empty comments
(a few other PushModel calls have similar formatting)
Member
Author
There was a problem hiding this comment.
I added those so clang format displayed them a separate line. I'll add comments.
Member
Author
|
Haven't tested this on Fuchsia yet. Will hold off on landing this till I do. |
abarth
reviewed
Oct 11, 2017
flow/layers/layer_builder.cc
Outdated
| #include "flutter/flow/layers/color_filter_layer.h" | ||
| #include "flutter/flow/layers/container_layer.h" | ||
| #include "flutter/flow/layers/layer.h" | ||
| #include "flutter/flow/layers/layer_builder.h" |
Contributor
There was a problem hiding this comment.
The primary header should be first, followed by a blank line, followed by the rest of the headers. This pattern ensures that each header can build on its own (and doesn't require other headers to be included first).
Contributor
|
|
liyuqian
added a commit
to liyuqian/engine
that referenced
this pull request
Sep 14, 2018
This essentially reverts flutter#4197 as no one is (or soon will be) implementing an alternative LayerBuilder. Let's just put everything in SceneBuilder to reduce the YAGNI (you aren't gonna need it) smell. This will also make retained rendering API changes much easier.
liyuqian
added a commit
that referenced
this pull request
Sep 14, 2018
This essentially reverts #4197 as no one is (or soon will be) implementing an alternative LayerBuilder. Let's just put everything in SceneBuilder to reduce the YAGNI (you aren't gonna need it) smell. This will also make retained rendering API changes much easier.
amirh
pushed a commit
to amirh/engine
that referenced
this pull request
Sep 21, 2018
This essentially reverts flutter#4197 as no one is (or soon will be) implementing an alternative LayerBuilder. Let's just put everything in SceneBuilder to reduce the YAGNI (you aren't gonna need it) smell. This will also make retained rendering API changes much easier.
amirh
pushed a commit
to amirh/engine
that referenced
this pull request
Sep 21, 2018
This essentially reverts flutter#4197 as no one is (or soon will be) implementing an alternative LayerBuilder. Let's just put everything in SceneBuilder to reduce the YAGNI (you aren't gonna need it) smell. This will also make retained rendering API changes much easier.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves all the logic of construction of the layer tree into flow.