Fix data loss when a root key contains another root key #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@getaarond thanks for the PR, do you mind checking why the travis build is failing? |
@amirziai it's a Python 3 import error that is unrelated to my changes. See here. Another PR is failing with the same issue. There are 2 more failing PRs with errors downloading the Python 3 binary for Ubuntu 16.04. See here and here. |
|
This code fixed an issue for me. Can we merge now that the tests are passing? |
Closes #51
|
@amirziai mind if we merge this? |
amirziai
approved these changes
Jan 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix the issue where a root key is lost if another root key contains it.
How to Verify
New test in
test_flatten.py:test_unflatten_with_key_loss_issue51Side Effects
No.
Resolves
Fixes #51
Tests
New test in
test_flatten.py:test_unflatten_with_key_loss_issue51All tests pass.
Code Reviewer(s)
@amirziai