Use module directory so util.py exists inside name space #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for the PR @padwasabimasala, can you check why the travis build is not failing? |
|
Thanks @amirziai. The build is failing because it cannot download the python 3.3 or pypy tarballs. This happens before the tests run and most likely was a fluke, of possibly the CI config needs to be updated. I dont have permissions to trigger builds on Travis but my guess is that they will run fine if run again. |
amirziai
approved these changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently util.py is installed directly into python site-packages which could cause a naming conflict.
Bug Fixes/New Features
This PR introduces a module directory so that util.py is in the flatten_json namespace.
How to Verify
Run the tests. Reinstall the module and see that util.py is installed in site-packages/flatten_json/util.py
Side Effects
Should have no side effects.
Tests
All existing tests pass. No new tests needed.