Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterable support #59

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Iterable support #59

wants to merge 3 commits into from

Conversation

guility
Copy link

@guility guility commented Oct 9, 2019

Checks object part is Iterable not (tuple, list, set)

Allows to use deal with numpy.arrays and subclasses inside the dictionaries.

Checks object part is Iterable not (tuple, list, set)
@amirziai
Copy link
Owner

thanks for contributing @guility . can you add a test that shows how not having this causes problems?

@pep8speaks
Copy link

pep8speaks commented Oct 22, 2019

Hello @guility! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 2186:1: W293 blank line contains whitespace

Comment last updated at 2019-10-22 16:49:27 UTC

@guility
Copy link
Author

guility commented Oct 22, 2019

@amirziai basically, if applying only to .jsons - there would be no such a problem.
BTW, if you try using it with some basic dictionaries containing custom iterables or numpy.ndarrays(which caused me to contribute) - you would have an issue.

You could check the test case in my latest commit to test your code with custom iterable.

@amirziai
Copy link
Owner

amirziai commented Oct 22, 2019

That's a great test! Thanks! Do you mind fixing the PEP8 issue too? See the comment from @pep8speaks ☝️

@amirziai
Copy link
Owner

amirziai commented Oct 22, 2019

also your branch is behind master, please merge the latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants