Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pyproject py versions #85

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Conversation

jmahlik
Copy link
Contributor

@jmahlik jmahlik commented Oct 23, 2023

Summary

The summary should expand on the title of the pull request. What is the expected effect of the
pull request? Specifically, indicate how the behavior will be different than before the pull
request.

Tests for 3.9, 3.10 and 3.11. It'd be great to add tests against 3.12 but it doesn't look like travis supports 3.12 yet. Also adds a basic pyproject.toml to support PEP 517 builds.

Bug Fixes/New Features

  • Tests on multiple python versions
  • PEP 517 support

How to Verify

Run the following to build the project. Let the CI run to validate the other changes.

python -m pip install build 
python -m build . 
ls -l ./dist/*

# The upload to pypi can be done with twine if desired, or one could manually upload the items under dist.
twine upload ./dist/*

Side Effects

Does the pull request contain any side effects? This should list non-obvious things that have
changed in the request.

Resolves

Fixes #84

Tests

What tests were created or changed for this feature or fix? Do all tests pass, and if not, why?

Will have to run the ci.

Code Reviewer(s)

@, @

@amirziai amirziai merged commit 92011e8 into amirziai:master Oct 27, 2023
@jmahlik jmahlik deleted the pyproject-py-versions branch October 27, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wheel on pypi?
2 participants