Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made og_entity_delete() work #131

Open
wants to merge 1 commit into
base: 8.x-1.x
Choose a base branch
from
Open

made og_entity_delete() work #131

wants to merge 1 commit into from

Conversation

matslats
Copy link

No description provided.

@matslats
Copy link
Author

My github fork is out of date and I can't see how to bring it back line with HEAD.
If I delete my branches will the pull requests such as this one be lost?
Why is a simple pull request like this waiting so long to be merged?

@zerolab
Copy link

zerolab commented Mar 2, 2016

Hi @matslats,

If I remember correctly, when you delete your branch the pull request becomes unusable. You are better off syncing your fork and rebasing on master.

To sync your fork follow https://help.github.com/articles/syncing-a-fork/
Once that is done, switch to your branch and do a git rebase master and push it to your fork on GitHub (the usual git push origin)

@matslats
Copy link
Author

matslats commented Mar 8, 2016

Thanks Dan it worked left me a bit disoriented though!

On Wed, Mar 2, 2016, at 07:33 PM, Dan Braghis wrote:

Hi @matslats[1],

If I remember correctly, when you delete your branch the pull request
becomes unusable. You are better off syncing your fork and rebasing
on master.

To sync your fork follow
https://help.github.com/articles/syncing-a-fork/

Once that is done, switch to your branch and do a git rebase master and
push it to your fork on GitHub (the usual git push origin)

— Reply to this email directly or view it on GitHub[2].

Links:

  1. https://github.com/matslats
  2. made og_entity_delete() work #131 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants