Change to anomaly start time; add test ids (opensearch-project#522)

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
amitgalitz · Jul 7, 2023 · 9920dfa · 9920dfa
1 parent 344aa3d
commit 9920dfa
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 5 deletions.
diff --git a/...ponents/FeatureAnywhereContextMenu/AssociatedDetectors/containers/AssociatedDetectors.tsx b/...ponents/FeatureAnywhereContextMenu/AssociatedDetectors/containers/AssociatedDetectors.tsx
@@ -314,6 +314,7 @@ function AssociatedDetectors({ embeddable, closeFlyout, setMode }) {
             <EuiFlexItem grow={false}>
               <div>
                 <EuiButton
+                  data-test-subj="associateDetectorButton"
                   fill
                   iconType="link"
                   onClick={() => {

diff --git a/public/components/FeatureAnywhereContextMenu/CreateAnomalyDetector/AddAnomalyDetector.tsx b/public/components/FeatureAnywhereContextMenu/CreateAnomalyDetector/AddAnomalyDetector.tsx
@@ -580,7 +580,7 @@ function AddAnomalyDetector({
                     <EuiSpacer size="m" />
 
                     <EnhancedAccordion
-                      id="detectorDetails"
+                      id="detectorDetailsAccordion"
                       title={detectorNameFromVis}
                       isOpen={accordionsOpen.detectorDetails}
                       onToggle={() => onAccordionToggle('detectorDetails')}
@@ -685,7 +685,7 @@ function AddAnomalyDetector({
                     <EuiSpacer size="m" />
 
                     <EnhancedAccordion
-                      id="advancedConfiguration"
+                      id="advancedConfigurationAccordion"
                       title="Advanced configuration"
                       isOpen={accordionsOpen.advancedConfiguration}
                       onToggle={() =>
@@ -838,7 +838,7 @@ function AddAnomalyDetector({
                     <EuiSpacer size="m" />
 
                     <EnhancedAccordion
-                      id="modelFeatures"
+                      id="modelFeaturesAccordion"
                       title="Features"
                       isOpen={accordionsOpen.modelFeatures}
                       onToggle={() => onAccordionToggle('modelFeatures')}
@@ -910,7 +910,7 @@ function AddAnomalyDetector({
                   {mode === FLYOUT_MODES.existing ? (
                     <EuiButton
                       fill={true}
-                      data-test-subj="adAnywhereCreateDetectorButton"
+                      data-test-subj="adAnywhereAssociateDetectorButton"
                       isLoading={formikProps.isSubmitting}
                       onClick={() => handleAssociate(selectedDetector)}
                     >

diff --git a/public/components/FeatureAnywhereContextMenu/EnhancedAccordion/EnhancedAccordion.tsx b/public/components/FeatureAnywhereContextMenu/EnhancedAccordion/EnhancedAccordion.tsx
@@ -51,6 +51,7 @@ const EnhancedAccordion = ({
           buttonContent={
             <div className="enhanced-accordion__title">
               <EuiTitle
+                data-test-subj="accordionTitleButton"
                 size="s"
                 onClick={onToggle}
                 role="button"

diff --git a/public/expressions/helpers.ts b/public/expressions/helpers.ts
@@ -74,7 +74,7 @@ export const convertAnomaliesToPointInTimeEventsVisLayer = (
 ): PointInTimeEventsVisLayer => {
   const events = anomalies.map((anomaly: AnomalyData) => {
     return {
-      timestamp: anomaly.startTime + (anomaly.endTime - anomaly.startTime) / 2,
+      timestamp: anomaly.startTime,
       metadata: {},
     };
   });

diff --git a/public/pages/DetectorConfig/containers/Features.tsx b/public/pages/DetectorConfig/containers/Features.tsx
@@ -234,6 +234,7 @@ export const Features = (props: FeaturesProps) => {
             titleSize="s"
           >
             <EuiBasicTable
+              data-test-subj="featureTable"
               items={sortedItems}
               columns={columns}
               cellProps={getCellProps}