Skip to content
This repository has been archived by the owner on Nov 21, 2024. It is now read-only.

Rewrite Waiting List Email #624

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

alexander-schoch-linuxdays
Copy link
Contributor

There's two cases why a user would receive the "events_waitignList" email:

  1. The event is full. In this case, they end up on the waiting list and can be accepted if people sign off.
  2. The event moderator has to approve of the participants, and thus all users end up on the waiting list.

The current text reads as follows:

Hello {{ name }}!

We are sorry to inform you that your signup for {{ event }} was rejected because there are no free spots available.

We put you on a waiting list and we will send you an email when a spot becomes available.

Best Regards,
AMIV

This text is well-suited for case 1, but very confusing for case 2. I got confused twice within one month about this now, so I'm creating a PR.

@suisseWalter
Copy link
Contributor

looks good. This has been a criticism for a long time. and this is a nice solution that doesn't require change any logic, the suggestion was always that there should be two different emails.

Copy link
Member

@nimro27 nimro27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@temparus
Copy link
Member

As we check for specific phrases in our unit tests, you should update the test cases in amivapi.tests.events.test_emails.py.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants