This repository has been archived by the owner on Apr 24, 2018. It is now read-only.
Allow to add the showcase view to a custom parent #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -387,6 +387,9 @@ public void showButton() { | |||
| final ShowcaseView showcaseView; | |||
| private final Activity activity; | |||
|
|
|||
| private ViewGroup mParent; | |||
There was a problem hiding this comment.
Could you remove the m prefix from these fields please? :)
|
Like the idea of this, just a couple of issues, and a conflict, but happy to merge once these have been addressed :) |
|
thanks for the comments. Should be better now. |
|
Looks great! There are still conflicts; just make sure you merge the master branch into your branch, and then that should work 👍 |
…_parent Conflicts: library/src/main/java/com/github/amlcurran/showcaseview/ShowcaseView.java
|
Should be good now, tell me if anything else is required. |
|
Awesome, thank you very much! I will make a release containing shortly :) |
amlcurran
added a commit
that referenced
this pull request
Oct 28, 2015
…iew_to_a_custom_parent Allow to add the showcase view to a custom parent
martinbonnin
deleted the
allow_to_add_the_showcase_view_to_a_custom_parent
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed this because at the startup of my app, the LoginFragment competes with the ShowcaseView to be on top of everything else in the Activity