Skip to content
This repository has been archived by the owner on Apr 24, 2018. It is now read-only.

makes it workable with api9 and 10 #310

Merged
merged 1 commit into from
Nov 6, 2015
Merged

makes it workable with api9 and 10 #310

merged 1 commit into from
Nov 6, 2015

Conversation

swolf91
Copy link
Contributor

@swolf91 swolf91 commented Oct 29, 2015

The minimun version of the library is set to android sdk 9 but unfortunately it doesn't work with an android version before sdk 11. This PR fixes this problem. It simply disables the animations for android 9 and 10. So if the showcase position changes it'll just jump to the new position. For me this behavior is okay for this old android versions.

@amlcurran
Copy link
Owner

Hi! Thanks for the PR, and sorry it isn't working.

I like what you've done, although would you mind doing it a slightly different way? If you see here https://github.com/amlcurran/ShowcaseView/blob/master/library/src/main/java/com/github/amlcurran/showcaseview/ShowcaseView.java#L96 I create an animator factory. Essentially, I was going to use polymorphism and make an animator factory that doesn't do animations. Would you mind doing it this way?

If you're not sure of what I mean then let me know; I'll be happy to accept the pull request and do it myself if so :)

Thanks!

@swolf91
Copy link
Contributor Author

swolf91 commented Nov 1, 2015

Thanks for your feedback. Yes, I know what you mean. I'll change my PR Wednesday and ping you if it's ready. Unfortunately I won't have time earlier.

@swolf91
Copy link
Contributor Author

swolf91 commented Nov 4, 2015

@amlcurran I updated the PR. I hope I did it like you want it. I'm not sure about the name of the AnimationFactory. I called it "Jumping" because it doesn't animate, it just jumps from one point to another. Let me know if you've a better name.

@amlcurran
Copy link
Owner

This is exactly what I was looking for :) going to make a few style changes, but more than happy to accept this. Thanks!!

amlcurran added a commit that referenced this pull request Nov 6, 2015
makes it workable with api9 and 10
@amlcurran amlcurran merged commit 075ae26 into amlcurran:master Nov 6, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants