This repository has been archived by the owner on Apr 24, 2018. It is now read-only.
Fix incorrect start position of showcase animation #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShowcaseView#setShowcasePosition adjusts the given coordinates for the location of the ShowcaseView inside the window. When ObjectAnimator calls getShowcaseY to get the starting value for the animation, the already adjusted value was returned, thus basically incorrectly applying the adjustment twice when the ObjectAnimator sets that value at the start of the animation. As a fix, hide the fact that the fields showcaseX and showcaseY are adjusted by returning the un-adjusted values from their getters.
|
oh man, good catch! Will give this a quick smoke test to make sure everything is alright and if it is, I'll merge :) |
|
Thanks for this! |
amlcurran
added a commit
that referenced
this pull request
Apr 6, 2016
amlcurran
added a commit
that referenced
this pull request
Apr 6, 2016
Fix #377, where changing the text wouldn't update the ShowcaseView
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #372.
ShowcaseView#setShowcasePositionadjusts the given coordinates for the location of the ShowcaseView inside the window.When ObjectAnimator calls
getShowcaseYto get the starting value for the animation, the already adjusted value was returned, thus basically incorrectly applying the adjustment twice when the ObjectAnimator sets that value at the start of the animation.In effect,
setShowcaseY(getShowcaseY())changed the value ofshowcaseY.As a fix, hide the fact that the fields
showcaseXandshowcaseYare adjusted by returning the un-adjusted values from their getters.