Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from ant-design:master #208

Closed
wants to merge 88 commits into from

Conversation

pull[bot]
Copy link

@pull pull bot commented Nov 7, 2023

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

zombieJ and others added 30 commits October 10, 2023 16:22
* docs: init

* chore: update example

* test: update test

* docs: update doc

* chore: fix lint

* chore: update limit
* feat: add ref

* feat: table support reference

* chore: rename

* chore: proxy

* test: add test case

* chore: fix lint

* docs: update desc

* docs: update desc

* docs: update desc

* chore: clean up

* chore: fix lint
chore: feature merge master
* feat: App support component

* test: update test case

* chore: update ts
* docs: init

* feat: support inherit

* test: update snapshot
* chore: bump rc-input-number

* test: update test case
* chore: bump rc-tabs

* chore: update limit

* chore: fix lint
chore: feature merge master
* fix: dropdown not trigger onOpenChange when click menu item

* chore: add source

* docs: update

* test: update test
* feat: start the implementation of the fullscreen prop in Spin

* docs: change main spin demo

* docs: enhance demo

* test: update snapshot

* fix: address pr comments

* fix: use logical property on fullscreen class

* fix: address pr review

* feat: Added background color token

* fix: remove onClick and change demo

* feat: change spin to white when fullcreen

also use the bgmask as background, removing the bgColor token

* fix: unused import

* test: update snapshot

* Update components/spin/style/index.tsx

Signed-off-by: lijianan <574980606@qq.com>

* fix: use white color from token

* fix: not needed interpolation and version

* fix: address pr review

* fix: tip prop was not working

* test: cover tip & fullscreen case

* fix: addrress pr coments

---------

Signed-off-by: lijianan <574980606@qq.com>
Co-authored-by: lijianan <574980606@qq.com>
Co-authored-by: MadCcc <1075746765@qq.com>
* feat: z-index manager

* feat: z-index manager

* feat: update snap

* chore: update site-limit

* feat: optimize code

* feat: optimize code

* feat: add test case

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code
chore: merge master into feature
* feat: Popconfirm support z-index manager

* Update components/popconfirm/__tests__/index.test.tsx

Signed-off-by: kiner-tang(文辉) <1127031143@qq.com>

---------

Signed-off-by: kiner-tang(文辉) <1127031143@qq.com>
* feat: Popover support z-index manager

* feat: update snap

* Update components/popover/__tests__/index.test.tsx

Signed-off-by: kiner-tang(文辉) <1127031143@qq.com>

---------

Signed-off-by: kiner-tang(文辉) <1127031143@qq.com>
* feat: Tooltip support z-index manager

* feat: optimize code
afc163 and others added 17 commits November 3, 2023 17:59
如果上一个 Preview Build 因为连续提交,会导致这里下载失败。直接把 if 逻辑提升一级
* style: fix Upload border color when dragover

* Update components/upload/style/dragger.ts

Signed-off-by: afc163 <afc163@gmail.com>

---------

Signed-off-by: afc163 <afc163@gmail.com>
Co-authored-by: robin.li <robin.li@webeye.com>
Co-authored-by: afc163 <afc163@gmail.com>
* docs: solve error about dropdown

* feat: update snap

* style: fix Upload border color when drag over (#45663)

* style: fix Upload border color when dragover

* Update components/upload/style/dragger.ts

Signed-off-by: afc163 <afc163@gmail.com>

---------

Signed-off-by: afc163 <afc163@gmail.com>
Co-authored-by: robin.li <robin.li@webeye.com>
Co-authored-by: afc163 <afc163@gmail.com>

* fix: test case error in React 16

---------

Signed-off-by: afc163 <afc163@gmail.com>
Co-authored-by: Oceansdeep7 <14208796@qq.com>
Co-authored-by: robin.li <robin.li@webeye.com>
Co-authored-by: afc163 <afc163@gmail.com>
* # This is a combination of 2 commits.
# This is the 1st commit message:

chore: add npm-check-updates

# The commit message #2 will be skipped:

# fixup! chore: add npm-check-updates
(cherry picked from commit f62e034897b7398ba304738433ddbe022147e6c0)

* ci: add upgrade-deps workflow

(cherry picked from commit 0a4a2827b59155757809f80450acfb7e5f63f4b3)

* chore: update rule

* chore: update

* chore: rename

* chore: update
* docs: optimize changelog

* Apply suggestions from code review

Co-authored-by: afc163 <afc163@gmail.com>
Signed-off-by: MadCcc <1075746765@qq.com>

---------

Signed-off-by: MadCcc <1075746765@qq.com>
Co-authored-by: afc163 <afc163@gmail.com>
* type: add generics to AppProps

* type: add generics to rootProps
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* fix: fix error when component === false

* fix: fix
Updated link for pull request template, updated capitalization for link names for consistency, removed additional contributor information link.

Signed-off-by: Aylee <114051913+Aylee-Shomali@users.noreply.github.com>
* fix: notification style width

* chore: code clean

* chore: update size-limit
Co-authored-by: afc163 <afc163@users.noreply.github.com>
* Delete .github/tests_checker.yml

Signed-off-by: afc163 <afc163@gmail.com>

* Delete .github/lock.yml

Signed-off-by: afc163 <afc163@gmail.com>

---------

Signed-off-by: afc163 <afc163@gmail.com>
Signed-off-by: afc163 <afc163@gmail.com>
* fix: update tag default background

* feat: remove unused code

---------

Co-authored-by: afc163 <afc163@gmail.com>
Copy link

Review changes with SemanticDiff

Copy link

restack-app bot commented Nov 7, 2023

No applications have been configured for previews targeting branch: master. To do so go to restack console and configure your applications for previews.

Copy link

commit-lint bot commented Nov 7, 2023

Features

Bug Fixes

Chore

Contributors

zombieJ, li-jia-nan, kiner-tang, Rafael-Martins, github-actions[bot]

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

Copy link

coderabbitai bot commented Nov 7, 2023

Important

Auto Review Skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.
  • @coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link

pr-code-reviewer bot commented Nov 7, 2023

👋 Hi there!

Everything looks good!


Automatically generated with the help of gpt-3.5-turbo.
Feedback? Please don't hesitate to drop me an email at webber@takken.io.

Copy link

github-actions bot commented Nov 7, 2023

Hi @pull[bot]. Thanks for your contribution. But, we don't have plan to add README of more languages. This current PR will be closed and team members will help on this.

Copy link

instapr bot commented Nov 7, 2023

The changes look good overall. There are just a few minor suggestions:

  • In file1.py, on line 10, let's use a more descriptive variable name instead of var1.
  • In file2.py, the indentation on lines 15-17 seems off. Can we fix that?
  • It might be a good idea to add some comments explaining the purpose of the code in file3.py.

Other than that, everything looks great!

Copy link

github-actions bot commented Nov 7, 2023

Hi @pull[bot]。

请注意,当前 PR 是分支间的互相合并,请使用 BranchAutoMerge 标签来进行自动合并。切记不要、不要、不要使用 Squash

Copy link

github-actions bot commented Nov 7, 2023

Prepare preview

@github-actions github-actions bot closed this Nov 7, 2023
Copy link

github-actions bot commented Nov 7, 2023

Hi @pull[bot]. Thanks for your contribution. The path .github/ or scripts/ and CHANGELOG is only maintained by team members. This current PR will be closed and team members will help on this.

@pull pull bot added the ⤵️ pull label Nov 7, 2023
Copy link

sweep-ai bot commented Nov 7, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.