[pull] master from ant-design:master #214

pull · 2023-11-10T00:20:24Z

See Commits and Changes for more details.

Can you help keep this open source service alive? 💖 Please sponsor : )

* docs: init * chore: update example * test: update test * docs: update doc * chore: fix lint * chore: update limit

* feat: add ref * feat: table support reference * chore: rename * chore: proxy * test: add test case * chore: fix lint * docs: update desc * docs: update desc * docs: update desc * chore: clean up * chore: fix lint

chore: feature merge master

* feat: App support component * test: update test case * chore: update ts

* docs: init * feat: support inherit * test: update snapshot

chore: merge master into feature

* chore: bump rc-input-number * test: update test case

* chore: bump rc-tabs * chore: update limit * chore: fix lint

chore: feature merge master

* fix: dropdown not trigger onOpenChange when click menu item * chore: add source * docs: update * test: update test

* feat: start the implementation of the fullscreen prop in Spin * docs: change main spin demo * docs: enhance demo * test: update snapshot * fix: address pr comments * fix: use logical property on fullscreen class * fix: address pr review * feat: Added background color token * fix: remove onClick and change demo * feat: change spin to white when fullcreen also use the bgmask as background, removing the bgColor token * fix: unused import * test: update snapshot * Update components/spin/style/index.tsx Signed-off-by: lijianan <574980606@qq.com> * fix: use white color from token * fix: not needed interpolation and version * fix: address pr review * fix: tip prop was not working * test: cover tip & fullscreen case * fix: addrress pr coments --------- Signed-off-by: lijianan <574980606@qq.com> Co-authored-by: lijianan <574980606@qq.com> Co-authored-by: MadCcc <1075746765@qq.com>

* feat: z-index manager * feat: z-index manager * feat: update snap * chore: update site-limit * feat: optimize code * feat: optimize code * feat: add test case * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code

chore: merge master into feature

* feat: Popconfirm support z-index manager * Update components/popconfirm/__tests__/index.test.tsx Signed-off-by: kiner-tang(文辉) <1127031143@qq.com> --------- Signed-off-by: kiner-tang(文辉) <1127031143@qq.com>

* feat: Popover support z-index manager * feat: update snap * Update components/popover/__tests__/index.test.tsx Signed-off-by: kiner-tang(文辉) <1127031143@qq.com> --------- Signed-off-by: kiner-tang(文辉) <1127031143@qq.com>

* feat: Tooltip support z-index manager * feat: optimize code

Co-authored-by: 伐宿 <fasu@uni-ubi.com>

Signed-off-by: Mattis Abrahamsson <60041024+MattisAbrahamsson@users.noreply.github.com>

…45731) Bumps [@types/isomorphic-fetch](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/isomorphic-fetch) from 0.0.38 to 0.0.39. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/isomorphic-fetch) --- updated-dependencies: - dependency-name: "@types/isomorphic-fetch" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [@dnd-kit/sortable](https://github.com/clauderic/dnd-kit/tree/HEAD/packages/sortable) from 7.0.2 to 8.0.0. - [Release notes](https://github.com/clauderic/dnd-kit/releases) - [Changelog](https://github.com/clauderic/dnd-kit/blob/master/packages/sortable/CHANGELOG.md) - [Commits](https://github.com/clauderic/dnd-kit/commits/@dnd-kit/sortable@8.0.0/packages/sortable) --- updated-dependencies: - dependency-name: "@dnd-kit/sortable" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [@dnd-kit/modifiers](https://github.com/clauderic/dnd-kit/tree/HEAD/packages/modifiers) from 6.0.1 to 7.0.0. - [Release notes](https://github.com/clauderic/dnd-kit/releases) - [Changelog](https://github.com/clauderic/dnd-kit/blob/master/packages/modifiers/CHANGELOG.md) - [Commits](https://github.com/clauderic/dnd-kit/commits/@dnd-kit/modifiers@7.0.0/packages/modifiers) --- updated-dependencies: - dependency-name: "@dnd-kit/modifiers" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update recommendation.zh-CN.md 原链接打开403 Signed-off-by: Nerohero <nerohero2020@163.com> * Apply suggestions from code review Signed-off-by: afc163 <afc163@gmail.com> * Update recommendation.en-US.md --------- Signed-off-by: Nerohero <nerohero2020@163.com> Signed-off-by: afc163 <afc163@gmail.com> Co-authored-by: afc163 <afc163@gmail.com>

* demo: add disabled demo * demo: Modify tooltip Disable demo Description * demo: Modify tooltip Disable demo Description

* chore: fix zIndex logic * chore: detect if needed * docs: update bug version * test: update snapshot * test: update snapshot * test: update snapshot

Bumps [@types/gtag.js](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/gtag.js) from 0.0.17 to 0.0.18. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/gtag.js) --- updated-dependencies: - dependency-name: "@types/gtag.js" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* docs: 5.11.1 changelog * docs: fix typo * docs: rm useless log

* test: update snapshot * test: update snapshot * test: update snapshot * test: update snapshot * test: update snapshot

Co-authored-by: afc163 <afc163@users.noreply.github.com>

restack-app · 2023-11-10T00:20:30Z

No applications have been configured for previews targeting branch: master. To do so go to restack console and configure your applications for previews.

semanticdiff-com · 2023-11-10T00:20:30Z

Review changes with SemanticDiff

commit-lint · 2023-11-10T00:20:31Z

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

@Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
@Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
@Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
@Commit-Lint merge disable will desactivate merge dependabot PR
@Commit-Lint review will approve dependabot PR
@Commit-Lint stop review will stop approve dependabot PR

pr-code-reviewer · 2023-11-10T00:20:33Z

👋 Hi there!

Everything looks good!

_{^{Automatically generated with the help of gpt-3.5-turbo.

Feedback? Please don't hesitate to drop me an email at webber@takken.io.}}

coderabbitai · 2023-11-10T00:20:37Z

Important

Auto Review Skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Tips

Chat with CodeRabbit Bot (`@coderabbitai`)

If you reply to a review comment from CodeRabbit, the bot will automatically respond.
To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
Note: Review comments are made on code diffs or files, not on the PR overview.
Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai help to get help.
@coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

instapr · 2023-11-10T00:20:37Z

Please add more specific details about the changes made in this pull request. It would be helpful to have a summary of the commits or a brief description of the changes.

github-actions · 2023-11-10T00:20:39Z

Hi @pull[bot]。

请注意，当前 PR 是分支间的互相合并，请使用 BranchAutoMerge 标签来进行自动合并。切记不要、不要、不要使用 Squash。

github-actions · 2023-11-10T00:20:40Z

github-actions · 2023-11-10T00:20:41Z

Hi @pull[bot]. Thanks for your contribution. The path .github/ or scripts/ and CHANGELOG is only maintained by team members. This current PR will be closed and team members will help on this.

github-actions · 2023-11-10T00:20:42Z

Hi @pull[bot]. Thanks for your contribution. But, we don't have plan to add README of more languages. This current PR will be closed and team members will help on this.

sweep-ai · 2023-11-10T00:21:31Z

Apply Sweep Rules to your PR?

Apply: All new business logic should have corresponding unit tests.
Apply: Refactor large functions to be more modular.

pr-explainer-bot · 2023-11-10T00:21:55Z

Pull Request Review Markdown Doc

Hey there! 👋 Here's a summary of the previous results for the pull request review. Let's dive in!

Changes

Updated .codesandbox/ci.json to use antd-reproduction-template-forked-jyh2k9 sandbox.
Updated .codesandbox/ci.json to use Node version 18.

Suggestions

In .dumi/theme/common/LiveCode.tsx, line 18, changed border to box-shadow with colorPrimaryBorder.
In .dumi/theme/common/LiveCode.tsx, line 22, changed border to box-shadow with colorPrimary.
In .eslintrc.js, added 'lodash/import-scope': 2 to the plugins array.

Bugs

In .github/lock.yml, deleted the entire file.
In .github/tests_checker.yml, deleted the entire file.
In .github/workflows/preview-deploy.yml, removed the if condition from the download site artifact step.
In .github/workflows/preview-deploy.yml, removed the if condition from the upload surge service step.
In .github/workflows/upgrade-deps.yml, added the entire file.
In .ncurc.js, added the entire file.
In CHANGELOG.zh-CN.md, line 4, changed - 优化 Popconfirm 组件 z-index 逻辑。[#45420](https://github.com/ant-design/ant-design/pull.

Improvements

Improvement suggestion: In the README.md file, line 94, instead of importing Button and DatePicker separately, you can use the import { Button, DatePicker } from 'antd'; syntax to import them together.

Rating

Rating: 7/10
Criteria:

Readability: The code is easy to understand and follow.
Performance: The code performs well and doesn't have any major performance issues.
Security: The code is secure and doesn't have any major security vulnerabilities.

That's it for the summary! If you have any further questions or need more details, feel free to ask. Keep up the great work! 🎉

zombieJ and others added 30 commits October 10, 2023 16:22

feat: Input & TextArea support count (#45140)

6af1d95

* docs: init * chore: update example * test: update test * docs: update doc * chore: fix lint * chore: update limit

feat: Table support scrollTo reference (#45245)

bef9539

* feat: add ref * feat: table support reference * chore: rename * chore: proxy * test: add test case * chore: fix lint * docs: update desc * docs: update desc * docs: update desc * chore: clean up * chore: fix lint

Merge pull request #45271 from ant-design/master

012e878

chore: feature merge master

feat: App support component (#45292)

eaf4949

* feat: App support component * test: update test case * chore: update ts

feat: Watermark support inherit to disable passing (#45319)

44e1493

* docs: init * feat: support inherit * test: update snapshot

Merge branch master into master-merge-feature

8b486f3

Merge branch master into master-merge-feature

5b47f16

feat: update snap

442e175

Merge branch 'master' into master-merge-feature

0de095c

fix: update snap

bb6ef6f

Merge branch 'master' into master-merge-feature

00d74a3

fix: update snap

f9e5547

feat: update snap

1474006

feat: update snap

cb7e11a

Merge pull request #45347 from ant-design/master-merge-feature

e62197a

chore: merge master into feature

fix: InputNumber dynamic formatter (#45325)

9a04519

* chore: bump rc-input-number * test: update test case

feat: Tabs items support destroyInactiveTabPane (#45359)

98a8d30

chore: bump rc-tabs (#45370)

11cdac4

* chore: bump rc-tabs * chore: update limit * chore: fix lint

Merge pull request #45381 from ant-design/master

d8140e0

chore: feature merge master

fix: dropdown not trigger onOpenChange when click menu item (#45378)

a337fee

* fix: dropdown not trigger onOpenChange when click menu item * chore: add source * docs: update * test: update test

feat: support dirty (#45389)

3ab42ad

feat: support changeOnBlur (#45395)

2e8e67f

Merge branch 'feature' into refactor-z-index-context

d51de67

chore: auto merge branches (#45444)

f25fd3c

chore: merge master into feature

Merge branch 'feature' into refactor-z-index-context

bff04cd

feat: Popconfirm support z-index manager (#45421)

0fd730a

* feat: Popconfirm support z-index manager * Update components/popconfirm/__tests__/index.test.tsx Signed-off-by: kiner-tang(文辉) <1127031143@qq.com> --------- Signed-off-by: kiner-tang(文辉) <1127031143@qq.com>

feat: Popover support z-index manager (#45420)

8c49b38

* feat: Popover support z-index manager * feat: update snap * Update components/popover/__tests__/index.test.tsx Signed-off-by: kiner-tang(文辉) <1127031143@qq.com> --------- Signed-off-by: kiner-tang(文辉) <1127031143@qq.com>

feat: Tooltip support z-index manager (#45422)

bf1468a

* feat: Tooltip support z-index manager * feat: optimize code

MadCcc and others added 16 commits November 8, 2023 16:27

fix: component token should work (#45721)

c3a63a9

docs: fix TreeSelect demo onChange log (#45722)

261ba8f

Co-authored-by: 伐宿 <fasu@uni-ubi.com>

docs: Fix typo in Drawer documentation (#45726)

39a5d2b

Signed-off-by: Mattis Abrahamsson <60041024+MattisAbrahamsson@users.noreply.github.com>

docs: add Upload disabled demo for debug usage (#45723)

406e4ae

fix: Description children missing key (#45757)

5261f1e

fix: Upload should show remove icon when showRemoveIcon is true (#45752)

c2ef52b

demo: add tooltip disabled demo (#45748)

5727ce0

* demo: add disabled demo * demo: Modify tooltip Disable demo Description * demo: Modify tooltip Disable demo Description

fix: Dropdown with nest menu zIndex error (#45761)

c31fc76

* chore: fix zIndex logic * chore: detect if needed * docs: update bug version * test: update snapshot * test: update snapshot * test: update snapshot

docs: 5.11.1 changelog (#45768)

9d57f6f

* docs: 5.11.1 changelog * docs: fix typo * docs: rm useless log

test: update snapshot (#45770)

f22f61d

* test: update snapshot * test: update snapshot * test: update snapshot * test: update snapshot * test: update snapshot

chore: upgrade deps (#45772)

6098906

Co-authored-by: afc163 <afc163@users.noreply.github.com>

github-actions bot closed this Nov 10, 2023

pull bot added the ⤵️ pull label Nov 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[pull] master from ant-design:master #214

[pull] master from ant-design:master #214

pull bot commented Nov 10, 2023 •

edited

Loading

restack-app bot commented Nov 10, 2023

semanticdiff-com bot commented Nov 10, 2023

commit-lint bot commented Nov 10, 2023

pr-code-reviewer bot commented Nov 10, 2023 •

edited

Loading

coderabbitai bot commented Nov 10, 2023

Auto Review Skipped

Chat with CodeRabbit Bot (`@coderabbitai`)

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

instapr bot commented Nov 10, 2023

github-actions bot commented Nov 10, 2023

github-actions bot commented Nov 10, 2023

github-actions bot commented Nov 10, 2023

github-actions bot commented Nov 10, 2023

sweep-ai bot commented Nov 10, 2023

pr-explainer-bot bot commented Nov 10, 2023

[pull] master from ant-design:master #214

[pull] master from ant-design:master #214

Conversation

pull bot commented Nov 10, 2023 • edited Loading

restack-app bot commented Nov 10, 2023

semanticdiff-com bot commented Nov 10, 2023

commit-lint bot commented Nov 10, 2023

Features

Bug Fixes

Chore

Contributors

pr-code-reviewer bot commented Nov 10, 2023 • edited Loading

👋 Hi there!

coderabbitai bot commented Nov 10, 2023

Auto Review Skipped

Chat with CodeRabbit Bot (@coderabbitai)

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

instapr bot commented Nov 10, 2023

github-actions bot commented Nov 10, 2023

github-actions bot commented Nov 10, 2023

github-actions bot commented Nov 10, 2023

github-actions bot commented Nov 10, 2023

sweep-ai bot commented Nov 10, 2023

Apply Sweep Rules to your PR?

pr-explainer-bot bot commented Nov 10, 2023

Pull Request Review Markdown Doc

Changes

Suggestions

Bugs

Improvements

Rating

pull bot commented Nov 10, 2023 •

edited

Loading

pr-code-reviewer bot commented Nov 10, 2023 •

edited

Loading

Chat with CodeRabbit Bot (`@coderabbitai`)

CodeRabbit Configration File (`.coderabbit.yaml`)