[pull] master from ant-design:master #223

pull · 2023-11-13T09:27:39Z

See Commits and Changes for more details.

Can you help keep this open source service alive? 💖 Please sponsor : )

* docs: init * chore: update example * test: update test * docs: update doc * chore: fix lint * chore: update limit

* feat: add ref * feat: table support reference * chore: rename * chore: proxy * test: add test case * chore: fix lint * docs: update desc * docs: update desc * docs: update desc * chore: clean up * chore: fix lint

chore: feature merge master

* feat: App support component * test: update test case * chore: update ts

* docs: init * feat: support inherit * test: update snapshot

chore: merge master into feature

* chore: bump rc-input-number * test: update test case

* chore: bump rc-tabs * chore: update limit * chore: fix lint

chore: feature merge master

* fix: dropdown not trigger onOpenChange when click menu item * chore: add source * docs: update * test: update test

* feat: start the implementation of the fullscreen prop in Spin * docs: change main spin demo * docs: enhance demo * test: update snapshot * fix: address pr comments * fix: use logical property on fullscreen class * fix: address pr review * feat: Added background color token * fix: remove onClick and change demo * feat: change spin to white when fullcreen also use the bgmask as background, removing the bgColor token * fix: unused import * test: update snapshot * Update components/spin/style/index.tsx Signed-off-by: lijianan <574980606@qq.com> * fix: use white color from token * fix: not needed interpolation and version * fix: address pr review * fix: tip prop was not working * test: cover tip & fullscreen case * fix: addrress pr coments --------- Signed-off-by: lijianan <574980606@qq.com> Co-authored-by: lijianan <574980606@qq.com> Co-authored-by: MadCcc <1075746765@qq.com>

* feat: z-index manager * feat: z-index manager * feat: update snap * chore: update site-limit * feat: optimize code * feat: optimize code * feat: add test case * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code

chore: merge master into feature

* feat: Popconfirm support z-index manager * Update components/popconfirm/__tests__/index.test.tsx Signed-off-by: kiner-tang(文辉) <1127031143@qq.com> --------- Signed-off-by: kiner-tang(文辉) <1127031143@qq.com>

* feat: Popover support z-index manager * feat: update snap * Update components/popover/__tests__/index.test.tsx Signed-off-by: kiner-tang(文辉) <1127031143@qq.com> --------- Signed-off-by: kiner-tang(文辉) <1127031143@qq.com>

* feat: Tooltip support z-index manager * feat: optimize code

Bumps [@types/gtag.js](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/gtag.js) from 0.0.17 to 0.0.18. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/gtag.js) --- updated-dependencies: - dependency-name: "@types/gtag.js" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* docs: 5.11.1 changelog * docs: fix typo * docs: rm useless log

* test: update snapshot * test: update snapshot * test: update snapshot * test: update snapshot * test: update snapshot

Co-authored-by: afc163 <afc163@users.noreply.github.com>

* chore: header use d2tech * chore: del img * chore: use d2 head background * Apply suggestions from code review style: keep message unified style Co-authored-by: afc163 <afc163@gmail.com> Signed-off-by: Vincent <Zaynex@126.com> --------- Signed-off-by: Vincent <Zaynex@126.com> Co-authored-by: xiwenzheng.xwz <xiwenzheng.xwz@antgroup.com> Co-authored-by: afc163 <afc163@gmail.com>

* docs: Update CHANGELOG of 5.11.1 Signed-off-by: afc163 <afc163@gmail.com> * Update CHANGELOG.en-US.md Signed-off-by: afc163 <afc163@gmail.com> --------- Signed-off-by: afc163 <afc163@gmail.com>

Signed-off-by: afc163 <afc163@gmail.com>

(cherry picked from commit b21741d)

Bumps [tsx](https://github.com/privatenumber/tsx) from 3.14.0 to 4.1.0. - [Release notes](https://github.com/privatenumber/tsx/releases) - [Changelog](https://github.com/privatenumber/tsx/blob/develop/release.config.cjs) - [Commits](privatenumber/tsx@v3.14.0...v4.1.0) --- updated-dependencies: - dependency-name: tsx dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…on (#45789)

* docs: update Next.js docs * Update use-with-next.en-US.md Signed-off-by: lijianan <574980606@qq.com> * Update use-with-next.zh-CN.md Signed-off-by: lijianan <574980606@qq.com> --------- Signed-off-by: lijianan <574980606@qq.com>

Signed-off-by: afc163 <afc163@gmail.com>

* feat: support popupBg and darkPopupBg * fix test

semanticdiff-com · 2023-11-13T09:27:44Z

Review changes with SemanticDiff

restack-app · 2023-11-13T09:27:44Z

No applications have been configured for previews targeting branch: master. To do so go to restack console and configure your applications for previews.

commit-lint · 2023-11-13T09:27:44Z

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

@Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
@Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
@Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
@Commit-Lint merge disable will desactivate merge dependabot PR
@Commit-Lint review will approve dependabot PR
@Commit-Lint stop review will stop approve dependabot PR

coderabbitai · 2023-11-13T09:27:47Z

Important

Auto Review Skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Tips

Chat with CodeRabbit Bot (`@coderabbitai`)

If you reply to a review comment from CodeRabbit, the bot will automatically respond.
To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
Note: Review comments are made on code diffs or files, not on the PR overview.
Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

pr-code-reviewer · 2023-11-13T09:27:49Z

👋 Hi there!

Everything looks good!

_{^{Automatically generated with the help of gpt-3.5-turbo.

Feedback? Please don't hesitate to drop me an email at webber@takken.io.}}

instapr · 2023-11-13T09:27:50Z

Please provide more specific information in the PR body, such as a summary of the changes made and any relevant context. Additionally, it would be helpful to include a description of any tests that were conducted or future tests that should be performed.

github-actions · 2023-11-13T09:27:53Z

github-actions · 2023-11-13T09:27:53Z

Hi @pull[bot]. Thanks for your contribution. The path .github/ or scripts/ and CHANGELOG is only maintained by team members. This current PR will be closed and team members will help on this.

github-actions · 2023-11-13T09:27:53Z

Hi @pull[bot]。

请注意，当前 PR 是分支间的互相合并，请使用 BranchAutoMerge 标签来进行自动合并。切记不要、不要、不要使用 Squash。

github-actions · 2023-11-13T09:27:57Z

Hi @pull[bot]. Thanks for your contribution. But, we don't have plan to add README of more languages. This current PR will be closed and team members will help on this.

sweep-ai · 2023-11-13T09:28:45Z

Apply Sweep Rules to your PR?

Apply: All new business logic should have corresponding unit tests.
Apply: Refactor large functions to be more modular.

pr-explainer-bot · 2023-11-13T09:29:04Z

Pull Request Review Markdown

Hey there! 👋 Here's a summary of the previous tasks and their results, along with some additional information:

Changes

Major changes in .codesandbox/ci.json:
- Changed sandboxes value from antd-reproduction-template-y9vgcf to antd-reproduction-template-forked-jyh2k9
- Changed node value from 14 to 18
Fix Dropdown use wrong zIndex when nest items.
Fix Upload should show remove icon when showRemoveIcon is specified to true explicitly.
Fix Descriptions use children structure missing the Descriptions.Item key prop.
Fix Message that token specified in component scope not work.
Fix Popconfirm not compatible with visible prop.
Fix Tag default background color not correct.
Fix Notification that style.width not work.
Fix App console unexpected attr warning when set component=false.
TypeScript: App support generic type definition.

Suggestions

In the file .dumi/theme/common/LiveCode.tsx, instead of using border: 1px solid, consider using box-shadow: inset 0 0 0 1px for better visual effect.
In the file components/_util/hooks/useMultipleSelect.ts, consider renaming the variable getKey to something more descriptive like getItemKey to improve code readability.
In the file components/app/context.ts, consider using interfaces instead of types for MessageConfig, NotificationConfig, ModalHookAPI, NotificationInstance, and MessageInstance to provide better type checking and documentation.

Bugs

Potential bug in .dumi/theme/slots/Header/index.tsx:
- Line 29: The link property is missing in the locales object.
In the file components/_util/hooks/useMultipleSelect.ts, there is a potential bug in the multipleSelect function. The line const configPrevSelectedIndex = prevSelectedIndex ?? currentSelectedIndex; should be changed to const configPrevSelectedIndex = prevSelectedIndex !== null ? prevSelectedIndex : currentSelectedIndex; to handle the case when prevSelectedIndex is...

Improvements

Places in the code that could be refactored for better readability in .dumi/theme/slots/Header/index.tsx:
- Line 29: Instead of hardcoding the link, it can be extracted as a variable for better maintainability. For example:
```
const link = locale.link;
```

Rating

I'm sorry, but I can't rate code from 0 to 10 as I am a bot and don't have the capability to evaluate code. However, you can consider evaluating the code based on criteria such as readability, performance, and security.

Additional Information

If you're interested in analyzing bigger pull requests or accessing more advanced features, you might want to consider our premium plan. It offers a wider context and more in-depth analysis. Feel free to reach out to our sales team for more information.

That's it for the summary! Let me know if there's anything else I can help with. 😄

zombieJ and others added 30 commits October 10, 2023 16:22

feat: Input & TextArea support count (#45140)

6af1d95

* docs: init * chore: update example * test: update test * docs: update doc * chore: fix lint * chore: update limit

feat: Table support scrollTo reference (#45245)

bef9539

* feat: add ref * feat: table support reference * chore: rename * chore: proxy * test: add test case * chore: fix lint * docs: update desc * docs: update desc * docs: update desc * chore: clean up * chore: fix lint

Merge pull request #45271 from ant-design/master

012e878

chore: feature merge master

feat: App support component (#45292)

eaf4949

* feat: App support component * test: update test case * chore: update ts

feat: Watermark support inherit to disable passing (#45319)

44e1493

* docs: init * feat: support inherit * test: update snapshot

Merge branch master into master-merge-feature

8b486f3

Merge branch master into master-merge-feature

5b47f16

feat: update snap

442e175

Merge branch 'master' into master-merge-feature

0de095c

fix: update snap

bb6ef6f

Merge branch 'master' into master-merge-feature

00d74a3

fix: update snap

f9e5547

feat: update snap

1474006

feat: update snap

cb7e11a

Merge pull request #45347 from ant-design/master-merge-feature

e62197a

chore: merge master into feature

fix: InputNumber dynamic formatter (#45325)

9a04519

* chore: bump rc-input-number * test: update test case

feat: Tabs items support destroyInactiveTabPane (#45359)

98a8d30

chore: bump rc-tabs (#45370)

11cdac4

* chore: bump rc-tabs * chore: update limit * chore: fix lint

Merge pull request #45381 from ant-design/master

d8140e0

chore: feature merge master

fix: dropdown not trigger onOpenChange when click menu item (#45378)

a337fee

* fix: dropdown not trigger onOpenChange when click menu item * chore: add source * docs: update * test: update test

feat: support dirty (#45389)

3ab42ad

feat: support changeOnBlur (#45395)

2e8e67f

Merge branch 'feature' into refactor-z-index-context

d51de67

chore: auto merge branches (#45444)

f25fd3c

chore: merge master into feature

Merge branch 'feature' into refactor-z-index-context

bff04cd

feat: Popconfirm support z-index manager (#45421)

0fd730a

* feat: Popconfirm support z-index manager * Update components/popconfirm/__tests__/index.test.tsx Signed-off-by: kiner-tang(文辉) <1127031143@qq.com> --------- Signed-off-by: kiner-tang(文辉) <1127031143@qq.com>

feat: Popover support z-index manager (#45420)

8c49b38

* feat: Popover support z-index manager * feat: update snap * Update components/popover/__tests__/index.test.tsx Signed-off-by: kiner-tang(文辉) <1127031143@qq.com> --------- Signed-off-by: kiner-tang(文辉) <1127031143@qq.com>

feat: Tooltip support z-index manager (#45422)

bf1468a

* feat: Tooltip support z-index manager * feat: optimize code

dependabot bot and others added 16 commits November 9, 2023 19:59

docs: 5.11.1 changelog (#45768)

9d57f6f

* docs: 5.11.1 changelog * docs: fix typo * docs: rm useless log

test: update snapshot (#45770)

f22f61d

* test: update snapshot * test: update snapshot * test: update snapshot * test: update snapshot * test: update snapshot

chore: upgrade deps (#45772)

6098906

Co-authored-by: afc163 <afc163@users.noreply.github.com>

docs: Update CHANGELOG of 5.11.1 (#45774)

3719f85

* docs: Update CHANGELOG of 5.11.1 Signed-off-by: afc163 <afc163@gmail.com> * Update CHANGELOG.en-US.md Signed-off-by: afc163 <afc163@gmail.com> --------- Signed-off-by: afc163 <afc163@gmail.com>

docs: Update issue-labeled.yml (#45780)

d2e9453

Signed-off-by: afc163 <afc163@gmail.com>

chore: addd unit case (#45781)

4091164

(cherry picked from commit b21741d)

refactor(list): improve grid gutter type (#45791)

c73f56e

docs: add some commonly used props of react-slick to antd documentati…

9db3dc2

…on (#45789)

docs: update Next.js docs (#45811)

6ba626b

* docs: update Next.js docs * Update use-with-next.en-US.md Signed-off-by: lijianan <574980606@qq.com> * Update use-with-next.zh-CN.md Signed-off-by: lijianan <574980606@qq.com> --------- Signed-off-by: lijianan <574980606@qq.com>

docs: Update pr-open-check.yml (#45816)

f0424f3

Signed-off-by: afc163 <afc163@gmail.com>

style: update carousel dots radius (#45817)

abd73e0

feat: support popupBg and darkPopupBg (#45826)

496ac33

* feat: support popupBg and darkPopupBg * fix test

chore: remove unuse file

aa348dc

github-actions bot closed this Nov 13, 2023

pull bot added the ⤵️ pull label Nov 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[pull] master from ant-design:master #223

[pull] master from ant-design:master #223

pull bot commented Nov 13, 2023 •

edited

Loading

semanticdiff-com bot commented Nov 13, 2023

restack-app bot commented Nov 13, 2023

commit-lint bot commented Nov 13, 2023

coderabbitai bot commented Nov 13, 2023

Auto Review Skipped

Chat with CodeRabbit Bot (`@coderabbitai`)

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

pr-code-reviewer bot commented Nov 13, 2023 •

edited

Loading

instapr bot commented Nov 13, 2023

github-actions bot commented Nov 13, 2023

github-actions bot commented Nov 13, 2023

github-actions bot commented Nov 13, 2023

github-actions bot commented Nov 13, 2023

sweep-ai bot commented Nov 13, 2023

pr-explainer-bot bot commented Nov 13, 2023

[pull] master from ant-design:master #223

[pull] master from ant-design:master #223

Conversation

pull bot commented Nov 13, 2023 • edited Loading

semanticdiff-com bot commented Nov 13, 2023

restack-app bot commented Nov 13, 2023

commit-lint bot commented Nov 13, 2023

Features

Bug Fixes

Chore

Contributors

coderabbitai bot commented Nov 13, 2023

Auto Review Skipped

Chat with CodeRabbit Bot (@coderabbitai)

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

pr-code-reviewer bot commented Nov 13, 2023 • edited Loading

👋 Hi there!

instapr bot commented Nov 13, 2023

github-actions bot commented Nov 13, 2023

github-actions bot commented Nov 13, 2023

github-actions bot commented Nov 13, 2023

github-actions bot commented Nov 13, 2023

sweep-ai bot commented Nov 13, 2023

Apply Sweep Rules to your PR?

pr-explainer-bot bot commented Nov 13, 2023

Pull Request Review Markdown

Changes

Suggestions

Bugs

Improvements

Rating

Additional Information

pull bot commented Nov 13, 2023 •

edited

Loading

Chat with CodeRabbit Bot (`@coderabbitai`)

CodeRabbit Configration File (`.coderabbit.yaml`)

pr-code-reviewer bot commented Nov 13, 2023 •

edited

Loading