Skip to content

Commit

Permalink
test: update expectation on windows for "should reject if launched br… (
Browse files Browse the repository at this point in the history
microsoft#27603)

…owser fails immediately"

The test has been failing on Windows since
f212fd1
  • Loading branch information
yury-s authored Oct 13, 2023
1 parent 6400e5c commit d6adfee
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tests/library/browsertype-launch.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,12 @@ it('should throw if page argument is passed', async ({ browserType, browserName
expect(waitError.message).toContain('can not specify page');
});

it('should reject if launched browser fails immediately', async ({ mode, browserType, asset }) => {
it('should reject if launched browser fails immediately', async ({ mode, browserType, asset, isWindows }) => {
it.skip(mode.startsWith('service'));

let waitError = null;
await browserType.launch({ executablePath: asset('dummy_bad_browser_executable.js') }).catch(e => waitError = e);
expect(waitError.message).toContain('Browser logs:');
expect(waitError.message).toContain(isWindows ? 'browserType.launch: spawn UNKNOWN' : 'Browser logs:');
});

it('should reject if executable path is invalid', async ({ browserType, mode }) => {
Expand Down

0 comments on commit d6adfee

Please sign in to comment.