Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from microsoft:main #52

Merged
merged 22 commits into from
Aug 9, 2023

Conversation

pull[bot]
Copy link

@pull pull bot commented Aug 7, 2023

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

mastrzyz and others added 4 commits August 7, 2023 10:03
…4567)

This opens a road to the "accept new screenshot" button in
Playwright tools.

References #24310
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
@restack-app
Copy link

restack-app bot commented Aug 7, 2023

No applications have been configured for previews targeting branch: main. To do so go to restack console and configure your applications for previews.

@pr-code-reviewer
Copy link

pr-code-reviewer bot commented Aug 7, 2023

👋 Hi there!

  1. The code should be refactored to use proper indentation and formatting for better readability.
  2. It would be beneficial to add comments or documentation to explain the purpose and functionality of each step or section in the workflow.
  3. Secret values, such as application IDs and client secrets, should be securely managed and stored, preferably using a secret management system provided by the CI/CD platform.


Automatically generated with the help of gpt-3.5-turbo.
Feedback? Please don't hesitate to drop me an email at webber@takken.io.

@instapr
Copy link

instapr bot commented Aug 7, 2023

The addition of the sponsor message in the pull request body is not necessary and adds clutter. Let's keep the focus on the actual changes.

@pr-explainer-bot
Copy link

Pull Request Review

Hey there! 👋 I've summarized the previous results for you. Here's a markdown document for your pull request review:

Changes

  1. In class-testconfig.md, line 160, there is a major change in the description of the grep option. It now mentions that the regular expression will be tested against the string that consists of the test file name, test.describe name (if any), and the test name divided by spaces.
  2. In class-testproject.md, line 119, there is a major change in the description of the grep option. It now mentions that the regular expression will be tested against the string that consists of the test file name, test.describe name (if any), and the test name divided by spaces.

Suggestions

  1. In class-testconfig.md, line 160, the description of the grep option could be improved by providing an example of how the regular expression is matched against the test file name, test.describe name, and the test name.
  2. In class-testproject.md, line 119, the description of the grep option could be improved by providing an example of how the regular expression is matched against the test file name, test.describe name, and the test name.

Bugs

  1. In class-testconfig.md, line 160, there is a potential bug. The regular expression is mentioned to be tested against the string that consists of the test file name, test.describe name (if any), and the test name divided by spaces. However, the example provided does not match this format.
  2. In class-testproject.md, line 119, there is a potential bug. The regular expression is mentioned to be tested against the string that consists of the test file name, test.describe name (if any), and the test name divided by spaces.

Improvements

  1. In the file test.d.ts, there are changes made to the grep option description in multiple places.
  2. In the file golden.spec.ts, there are changes made to the expected snapshot paths.
  3. In the file test.d.ts, line 164, the test.describe name is divided by spaces. It should be divided by hyphens instead.
  4. In the file test.d.ts, line 791, the regular expression description should mention that it will be tested against the string that consists of the test file name, test.describe name (if any), and the test name divided by spaces.
  5. In the file test.d.ts, line 1540, the regular expression description should mention that it will be tested against the string that consists of the test file name, test.describe name (if any), and the test name divided by spaces.
  6. In the file test.d.ts, line 6406, the test.describe name is divided by spaces. It should be divided by hyphens instead.
  7. In the file golden.spec.ts, line 156, the expected snapshot path should match the regular expression /a\.spec\.js-snapshots\.snapshot\.txt/.
  8. In the file golden.spec.ts, line 569, the expected snapshot path should match the regular expression /a\.spec\.js-snapshots\.snapshot\.png/.
  9. In the file golden.spec.ts, line 877, the snapshot path should be updated to golden-should-attach-expected-actual-diff-with-snapshot-path-playwright-test/a.spec.js-snapshots/test/path/snapshot.png.
  10. In the file golden.spec.ts, line 916, the snapshot path should be updated to golden-should-attach-expected-actual-diff-playwright-test/a.spec.js-snapshots/snapshot.png.
  11. In the file golden.spec.ts, line 957, the snapshot path should be updated to golden-should-attach-expected-actual-diff-for-different-sizes-playwright-test/a.spec.js-snapshots/snapshot.png.
  12. In the file reporter-html.spec.ts, line 195, the text selector for 'Screenshots' should be updated to text="Screenshots".

Rating

Overall code rating: 8/10

Feel free to review the changes, suggestions, bugs, improvements, and the code rating. Let me know if you need any further assistance! 😄

dgozman added 2 commits August 7, 2023 13:38
Always ensure unique project/test ids across blobs.
Show `reportName` as a label in the html report.

References #24451.
@pull pull bot added the ⤵️ pull label Aug 7, 2023
dgozman and others added 16 commits August 7, 2023 16:26
…26332)

This page is going to be the "page for reuse", so it should not be
marked as "server-side-only" and should issue all required events.

Fixes #24574.
We cannot import a Symbol to isomorphic code from config. Instead,
__projectId property is used.
The credentials are created with 
`az ad sp create-for-rbac --name "playwright-github-actions" --role
"Storage Blob Data Contributor" --scopes /subscriptions/<subscription
id>/resourceGroups/<resource
group>/providers/Microsoft.Storage/storageAccounts/<storage account>`

We cannot use `azure/login@v1` for login as it does not see to properly
propagate credentials to `azcopy` in the next step (there are some
reports about keyring problems on linux based actions).
@ammar-ahmed-butt ammar-ahmed-butt merged commit d9992c3 into ammar-knowledge:main Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants