-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] main from microsoft:main #52
Conversation
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
No applications have been configured for previews targeting branch: main. To do so go to restack console and configure your applications for previews. |
👋 Hi there!
|
The addition of the sponsor message in the pull request body is not necessary and adds clutter. Let's keep the focus on the actual changes. |
Pull Request ReviewHey there! 👋 I've summarized the previous results for you. Here's a markdown document for your pull request review: Changes
Suggestions
Bugs
Improvements
RatingOverall code rating: 8/10 Feel free to review the changes, suggestions, bugs, improvements, and the code rating. Let me know if you need any further assistance! 😄 |
Always ensure unique project/test ids across blobs. Show `reportName` as a label in the html report. References #24451.
This regressed in #25017
We cannot import a Symbol to isomorphic code from config. Instead, __projectId property is used.
The credentials are created with `az ad sp create-for-rbac --name "playwright-github-actions" --role "Storage Blob Data Contributor" --scopes /subscriptions/<subscription id>/resourceGroups/<resource group>/providers/Microsoft.Storage/storageAccounts/<storage account>` We cannot use `azure/login@v1` for login as it does not see to properly propagate credentials to `azcopy` in the next step (there are some reports about keyring problems on linux based actions).
…26380) Pass all credentials via environment variable as described on [this page](https://learn.microsoft.com/en-us/azure/storage/common/storage-use-azcopy-authorize-azure-active-directory#authorize-a-service-principal-by-using-a-client-secret-1) instead of using `azcopy login`.
See Commits and Changes for more details.
Created by pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )