Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] next from storybookjs:next #1

Merged
merged 1,477 commits into from
Dec 14, 2023

Conversation

pull[bot]
Copy link

@pull pull bot commented Nov 15, 2023

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

Copy link

restack-app bot commented Nov 15, 2023

No applications have been configured for previews targeting branch: next. To do so go to restack console and configure your applications for previews.

Copy link

Review changes with SemanticDiff

Copy link

coderabbitai bot commented Nov 15, 2023

Important

Auto Review Skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can reply to a review comment made by CodeRabbit.
  • You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
  • You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link

commit-lint bot commented Nov 15, 2023

Features

  • tighter integration with sveltekit (dca97a1)

Contributors

valentinpalkovic, paoloricciuti, JReinhold, storybook-bot, ndelangen, kasperpeulen

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

Copy link

pr-code-reviewer bot commented Nov 15, 2023

👋 Hi there!

The code diff suggests the following improvements:

  1. Replace "yarn ts-node" with "node --loader esbuild-register/loader -r esbuild-register" to improve the performance and efficiency of running the "event-log-collector.ts" and "event-log-checker" scripts.
  2. Modify the command in the job at line 334 to use the suggested improvement: "node --loader esbuild-register/loader -r esbuild-register ./event-log-checker build $TEMPLATE".
  3. Add a missing command after "- report-workflow-on-failure" at line 472 to complete the configuration file.


Automatically generated with the help of gpt-3.5-turbo.
Feedback? Please don't hesitate to drop me an email at webber@takken.io.

Copy link

instapr bot commented Nov 15, 2023

@colleague_name Overall, the code changes look good. Thank you for addressing all the requested changes. Just a couple of minor comments:

  • In file1.py, please consider adding comments to explain the purpose of the function at line 42.
  • In file2.py, instead of using a nested loop at line 24, you can optimize it using a dictionary lookup.

Let me know if you have any questions. Good job!

Copy link

Pull Request Review - Summary

Hey there! 👋 Here's a summary of the previous results for the pull request review:

Changes

  1. Updated version numbers for various addons in package.json - Details
  2. Improved config loading and naming in FastBuild - Details
  3. Reverted defaulting to SWC in TestBuild, but kept using esbuild for minification - Details
  4. Added newer device viewports in Viewport - Details
  5. Prevented non-deterministic build output in Vite - Details

Suggestions

  • Consider using esbuild-register/loader instead of yarn ts-node in .circleci/config.yml - Details
  • Change the extends value to .eslintrc.cjs in .eslintrc.js - Details

Bugs

  • No potential bugs found in the code - Details

Improvements

  • Refactor the check and prep scripts in package.json for better readability - Details

Rating

Overall code rating: 8/10

  • The code is generally readable and well-structured.
  • The use of version control and clear commit messages helps with understanding the changes made.
  • The performance and security aspects seem to be handled properly.

Please let me know if you need any further assistance! 😄

Note: If you have a premium plan, you can analyze bigger pull requests with more context.

@pull pull bot added the ⤵️ pull label Nov 15, 2023
Copy link

sweep-ai bot commented Nov 15, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

shilman and others added 29 commits December 11, 2023 20:34
Addons: Remove unused postinstall package
…ation

Sandboxes: Use yarn1 for sandbox generation
…-to-node-18

Maintenance: Set engines field to Node.js >= 18 for packages
Blocks: Fix Subtitle block for unattached docs pages
….0-alpha.2

Release: Prerelease 8.0.0-alpha.3
Angular: Add random attribute to bootstrapped selector
…tsconfig

Angular: Reduce the warnings from `ts-loader` via stricter list of `includes`
Docs: Explain how to clean local files for contributers
Blocks: Render colors in the same order as provided
…bpack-sandboxes

Build: Remove preact-webpack5 sandboxes
…modules

SvelteKit: Fix missing `$app` modules
@ammar-ahmed-butt ammar-ahmed-butt merged commit e93ea1b into ammar-knowledge:next Dec 14, 2023
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.