Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A couple suggestions for the optimization level #67

Closed
FabioPedretti opened this issue Dec 14, 2020 · 2 comments
Closed

A couple suggestions for the optimization level #67

FabioPedretti opened this issue Dec 14, 2020 · 2 comments

Comments

@FabioPedretti
Copy link

  1. Optimizations should be shown with a bulleted list (or putting them inside a table), so it should be easier to read them (especially on smaller resolution screen, when the lines may break).
  2. To have a better understanding of the optimizations, it would be nice to also show the disabled ones (eventually with different colors), in the order of the bitmask for configuring them.

I think these suggestions would also easie calculating the bitmask to make changes to the opcache configuration.

Thanks.

@amnuts amnuts mentioned this issue Dec 16, 2020
amnuts added a commit that referenced this issue Dec 16, 2020
* Fixed spaceship operator regression
* Remove 'empty' get parameter (#66)
* Improved layout of arrays in directive list (eg, optimisation values) (#67)
* Added optimisation value to the list alongside text equivalent.
* Bumping version and updating readme
@amnuts
Copy link
Owner

amnuts commented Dec 16, 2020

Thanks for your input @FabioPedretti. I've addressed some of this in the new release (3.2.1).

I've improved the optimisation output by putting then in a list with a little extra padding around. I've hidden the bullet points, but they're legible enough as-is, I believe.

I can't really make the change to add the non-used optimisation levels and colour them differently without a bit more of a major modification, and I'm not overly convinced myself it's needed. But as a bit of a compromise I have added the bitmask value for the levels alongside their text output. Would still need to calculate things, but might make it a little easier.

I'll consider the request for the non-used values for another time, though.

@amnuts amnuts closed this as completed Dec 16, 2020
@FabioPedretti
Copy link
Author

Thanks!

humengcn pushed a commit to humengcn/opcache-gui that referenced this issue Dec 31, 2020
* Fixed spaceship operator regression
* Remove 'empty' get parameter (amnuts#66)
* Improved layout of arrays in directive list (eg, optimisation values) (amnuts#67)
* Added optimisation value to the list alongside text equivalent.
* Bumping version and updating readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants