Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added HTTP Authentication #33

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added HTTP Authentication #33

wants to merge 3 commits into from

Conversation

msigley
Copy link

@msigley msigley commented Apr 3, 2018

No description provided.

@bbalet
Copy link
Contributor

bbalet commented Apr 3, 2018

Please don't merge this PR.
If you want to restrict the access, you can move the script in a sub folder and setup your web server accordingly (.htacces in this folder or nginx conf for this path) Moreover, the problem of this PR is that it default this behaviour for everyone.

@msigley
Copy link
Author

msigley commented Apr 4, 2018

I have disabled the http authentication by default to preserve the existing behavior.

I must say though that it is not a very good idea security wise to have the script publicly accessible by default. The changes I made were based on the default functionality of the wincache gui script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msigley @bbalet