Dev #11
Merged
Dev #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a comprehensive overhaul of the widget system to improve layout consistency and usability. Key changes include: - Addition of a new `media-widget` to manage media playback information, with customizable labels and icons. - Refactoring existing widgets to utilize a unified container layout, enhancing styling and responsiveness. - Introduction of dynamic label creation for better handling of icon and text display in widgets. - Improved error handling and data fetching mechanisms for weather and media updates. These enhancements aim to provide a more cohesive user experience and facilitate easier maintenance and future feature additions.
Updated the weather widget to use a new API for fetching weather data, enhancing accuracy and performance. Removed the previous weather API implementation and consolidated configuration options. Added support for dynamic icon updates based on weather conditions and improved error handling during data retrieval. Additionally, updated the README with installation instructions for Nerd Fonts and added a demo image for the YASB widget. This refactor streamlines the weather functionality and enhances user experience by providing more reliable weather information.
Media widget improvements
Hopefully this solves weird behaviour where the media detection freezes until restart. The code with dynamic size introduced another stream open, but we never close them. Now we only use a single stream call, and always close it.
Fixes small bug where if you close a media player playing a certain song, and reopen it and continue, the thumbnail does not load because the title and artist are the same. Now, if media info is ever None, it wipes the last title and artist used for thumbnail detect.
bugfix(media): winsdk stream stability
…ehavior Added a paint event to the OverlayWidget to render a translucent background, preventing interactions with underlying widgets. This improves user experience by clearly indicating that the overlay is active. Additionally, the MainWindow now has application modal behavior, ensuring that it remains on top of other windows until closed, further enhancing focus on the power menu.
Updated the configuration to include a new layout option, 'right_main_vertical_stack', in the widgets section.
Small changes that allow you to set value-dependent colors for the icons of the power and memory widget. Most of the code to make this happen was still left (as well as all parameters in the schema), but the CSS properties were missing. Added the property setting in code and added disabled template CSS code for the colors. The template colors should be consistent with the rest of the bar (Catppuccin Mocha)
Simpler way of refreshing the stylesheets. More consistent with the other code.
When media widget is floating, you could see a thin bar of pixels when no media was playing. Solved by hiding the whole widget frame instead of just the container.
Replace parameter specifically for label toggle by simply clearing the artist/title fields to elicit thumbnail update.
Implements a corner rounding procedure for the media thumbnail. This cannot be achieved by CSS, so we need to make the corners transparent to mimic round corners. Using `thumbnail_corner_radius` users can set the rounding to match their CSS settings, or set it to 0 for default square corners.
feat(power/mem): Reintroduce value-dependent icon color
Fixes the crash which is caused by an asyncio event loop that is still running, whilst the bar is being deleted. Fixed by cancelling all asyncio tasks before deleting the bar. Still throws a lot of exceptions in the logs when this happens, but better than crash.
feat(media): Rounded thumbnail corners
This commit introduces a new GitHub notifications widget that fetches and displays unread notifications from the user's GitHub account. Additionally, error handling has been improved in the configuration loading process, ensuring that any issues are logged appropriately. The README and stylesheets have been updated to include references to the new GitHub widget, enhancing documentation and visual consistency across the application.
Added error handling for subprocess.Popen in the ApplicationsWidget class. If an exception occurs during the launch of an application, it now logs an error message instead of failing silently. This improves debugging and user experience by providing clearer insights into issues when starting applications.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.