chore: fix error message to be less misleading #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, good find. Thanks. |
|
Given the nature of the fix, I'm not doing a release immediately for this. Will wait a bit (2-3 weeks) to see if any other changes come through. Let me know if you feel differently. |
|
Thanks for the quick reaction! ✨ Yeah, no worries. I found an easy temporary workaround which should do the trick until you do the next release. Take your time! ☕ |
|
FYI, this is now released as v0.8.12. Thanks for your contribution to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
I'm a downstream user of this crate and I stumbled across the error message when no valid browser is found. (I only have librewolf installed and it's not caught by the defaults).
The error message is talking about setting the
BROWSERSvariable while the code is using theBROWSERvariable.This PR corrects the error message to be more useful.