Prepare for refactoring tests #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jrmhaig
commented
Mar 28, 2024
jrmhaig
commented
- Notes on plan for refactoring tests
- Create pipeline to run Rubocop
All supported versions of Active Record can now use sqlite3 version 1.6 so there is no need to explicitly set it in each gemfile.
The 'default' option was changed to defined a long time ago.
Minor updates of Rubocop and RSpec can cause unexpected failures in the pipeline that are not related to the changes that are being made. To avoid this updates are restricted to patch updates.
jrmhaig
force-pushed
the
test_refactor_notes
branch
4 times, most recently
from
d9511ab
to
62136a9
Compare
Tests for the unreleased version of Active Record are now in a separate file so that a failure does not cancell other tests. Really, Github Actions should have an 'allow failure' option.
jrmhaig
force-pushed
the
test_refactor_notes
branch
from
4b175d3
to
f32c545
Compare
jrmhaig
force-pushed
the
test_refactor_notes
branch
3 times, most recently
from
d645a1e
to
9a13801
Compare
jrmhaig
force-pushed
the
test_refactor_notes
branch
from
9a13801
to
8a91618
Compare
jrmhaig
force-pushed
the
test_refactor_notes
branch
from
4b75bc6
to
d05c298
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.