Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass coder to serialize as keyword argument #127

Merged
merged 1 commit into from
Jun 30, 2024

Conversation

jrmhaig
Copy link
Collaborator

@jrmhaig jrmhaig commented Jun 29, 2024

Passing coder to serialize as a positional argument is deprecated and will cause errors in Active Record after 7.1.

Fixes #125

@coveralls
Copy link

Coverage Status

coverage: 95.324%. remained the same
when pulling 930be32 on jrmhaig:fix_deprecation_in_serialize
into ca0ab62 on amoeba-rb:master.

@coveralls
Copy link

Coverage Status

coverage: 95.324%. remained the same
when pulling 930be32 on jrmhaig:fix_deprecation_in_serialize
into ca0ab62 on amoeba-rb:master.

@coveralls
Copy link

Coverage Status

coverage: 95.324%. remained the same
when pulling 930be32 on jrmhaig:fix_deprecation_in_serialize
into ca0ab62 on amoeba-rb:master.

@coveralls
Copy link

Coverage Status

coverage: 95.324%. remained the same
when pulling 930be32 on jrmhaig:fix_deprecation_in_serialize
into ca0ab62 on amoeba-rb:master.

@coveralls
Copy link

Coverage Status

coverage: 93.31% (-2.0%) from 95.324%
when pulling 930be32 on jrmhaig:fix_deprecation_in_serialize
into ca0ab62 on amoeba-rb:master.

Passing coder to serialize as a positional argument is deprecated and will
cause errors in Active Record after 7.1.
@jrmhaig jrmhaig force-pushed the fix_deprecation_in_serialize branch from 930be32 to fb0712d Compare June 30, 2024 08:16
@coveralls
Copy link

Coverage Status

coverage: 95.324%. remained the same
when pulling fb0712d on jrmhaig:fix_deprecation_in_serialize
into ca0ab62 on amoeba-rb:master.

@coveralls
Copy link

Coverage Status

coverage: 95.324%. remained the same
when pulling fb0712d on jrmhaig:fix_deprecation_in_serialize
into ca0ab62 on amoeba-rb:master.

@coveralls
Copy link

Coverage Status

coverage: 95.324%. remained the same
when pulling fb0712d on jrmhaig:fix_deprecation_in_serialize
into ca0ab62 on amoeba-rb:master.

@coveralls
Copy link

Coverage Status

coverage: 95.324%. remained the same
when pulling fb0712d on jrmhaig:fix_deprecation_in_serialize
into ca0ab62 on amoeba-rb:master.

@coveralls
Copy link

Coverage Status

coverage: 93.31% (-2.0%) from 95.324%
when pulling fb0712d on jrmhaig:fix_deprecation_in_serialize
into ca0ab62 on amoeba-rb:master.

@jrmhaig jrmhaig merged commit 6adbbc5 into amoeba-rb:master Jun 30, 2024
22 of 23 checks passed
@jrmhaig jrmhaig deleted the fix_deprecation_in_serialize branch June 30, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated second argument on serialize option in class used in tests
2 participants