Bug/ambig parse token

.vscode/settings.json

@@ -2,13 +2,9 @@
   "[python]": {
     "editor.defaultFormatter": "ms-python.black-formatter"
   },
-  "python.formatting.provider": "none",
   "python.testing.pytestArgs": ["heimdallm", "-s"],
   "python.testing.unittestEnabled": false,
   "python.testing.pytestEnabled": true,
   "editor.rulers": [88],
-  "notebook.formatOnSave.enabled": true,
-  "python.linting.flake8Enabled": false,
-  "python.linting.mypyEnabled": true,
-  "python.linting.enabled": true
+  "notebook.formatOnSave.enabled": true
 }

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 1.0.3 - 2/3/24
+
+- Bugfix where elided tree from a boolean token triggered ambiguity resolver
+
 ## 1.0.2 - 11/10/23
 
 - Resolving Dependabot suggestions

heimdallm/bifrosts/sql/mysql/select/grammar.lark

@@ -114,7 +114,7 @@ between_comparison : value (_WS NOT)? _WS BETWEEN _WS value _WS AND _WS value
 // are declared, so we cannot use this there
 ?value : NUMBER
     | string
-    | boolean
+    | BOOLEAN
     | NULL
     | NUMBER_PREFIX? value_expr
     | NUMBER_PREFIX? fq_column
@@ -135,7 +135,7 @@ function : FUNCTION_NAME "(" \
     ")"
 FUNCTION_NAME : /[a-zA-Z_]+/
 
-?boolean : TRUE | FALSE
+BOOLEAN : TRUE | FALSE
 ?string : ESCAPED_STRING
 
 // a placeholder for a value passed in as a parameter at query execution time

heimdallm/bifrosts/sql/postgres/select/grammar.lark

@@ -117,7 +117,7 @@ fts_comparison : value "@@" value
 // are declared, so we cannot use this there
 ?value : PREFIX_CAST? (NUMBER
     | string
-    | boolean
+    | BOOLEAN
     | NULL
     | NUMBER_PREFIX? value_expr
     | NUMBER_PREFIX? fq_column
@@ -143,7 +143,7 @@ SUBSTRING_FN_NAME : "substring"i
 EXTRACT_FN_NAME : "extract"i
 CAST_FN_NAME : "cast"i
 
-?boolean : TRUE | FALSE
+BOOLEAN : TRUE | FALSE
 ?string : ESCAPE_PREFIX? ESCAPED_STRING
 
 // a placeholder for a value passed in as a parameter at query execution time

heimdallm/bifrosts/sql/sqlite/select/grammar.lark

@@ -117,7 +117,7 @@ between_comparison : value (_WS NOT)? _WS BETWEEN _WS value _WS AND _WS value
 // are declared, so we cannot use this there
 ?value : NUMBER
     | string
-    | boolean
+    | BOOLEAN
     | NULL
     | NUMBER_PREFIX? value_expr
     | NUMBER_PREFIX? fq_column
@@ -136,7 +136,7 @@ function : FUNCTION_NAME "(" \
     ")"
 FUNCTION_NAME : /[a-zA-Z_]+/
 
-?boolean : TRUE | FALSE
+BOOLEAN : TRUE | FALSE
 ?string : ESCAPED_STRING
 
 // a placeholder for a value passed in as a parameter at query execution time

heimdallm/bifrosts/sql/tests/sql/select/test_ambiguous.py

@@ -24,3 +24,20 @@ def test_ambiguous_arith(dialect: str, Bifrost: Type[Bifrost]):
     """
 
     bifrost.traverse(query)
+
+
+@dialects()
+def test_ambiguous_bool(dialect: str, Bifrost: Type[Bifrost]):
+    """A regression test to ensure that boolean tokens do not trigger the ambiguity
+    resolver"""
+    bifrost = Bifrost.validation_only(PermissiveConstraints())
+
+    query = """
+SELECT
+    col
+FROM
+     postings AS p
+WHERE
+     p.is_hired = true
+     """
+    bifrost.traverse(query)

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "heimdallm"
-version = "1.0.2"
+version = "1.0.3"
 description = "Construct trusted SQL queries from untrusted input"
 homepage = "https://github.com/amoffat/HeimdaLLM"
 repository = "https://github.com/amoffat/HeimdaLLM"