Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glob wrapper breaks glob(.., root_dir=someething) #708

Closed
Pistahh opened this issue Nov 16, 2023 · 1 comment · Fixed by #709
Closed

glob wrapper breaks glob(.., root_dir=someething) #708

Pistahh opened this issue Nov 16, 2023 · 1 comment · Fixed by #709

Comments

@Pistahh
Copy link
Contributor

Pistahh commented Nov 16, 2023

Current glob wrapper only considers the "recursive" argument, but glob.glob supports much more. When using the sh module, it breaks calls that use other parameters too.
Pistahh added a commit to Pistahh/python-sh that referenced this issue Nov 16, 2023
@Pistahh
Fix glob
58f304e 
Fixes amoffat#708

glob.glob has many possible arguments but the current wrapping solution
doesn't cover all them.

This change directly passes all args (positional and kw) as-is to the
wrapped function.
@Pistahh Pistahh mentioned this issue Nov 16, 2023
Merged
@amoffat
Copy link
Owner

amoffat commented Nov 16, 2023

Cool, thanks for contributing the PR

Pistahh added a commit to Pistahh/python-sh that referenced this issue Nov 20, 2023
@Pistahh
Fix glob
ba8ce1a 
Fixes amoffat#708

glob.glob has many possible arguments but the current wrapping solution
doesn't cover all them.

This change directly passes all args (positional and kw) as-is to the
wrapped function.
Pistahh added a commit to Pistahh/python-sh that referenced this issue Nov 20, 2023
@Pistahh
Fix glob
2aca0fc 
Fixes amoffat#708

glob.glob has many possible arguments but the current wrapping solution
doesn't cover all them.

This change directly passes all args (positional and kw) as-is to the
wrapped function.
Pistahh added a commit to Pistahh/python-sh that referenced this issue Nov 20, 2023
@Pistahh
Fix glob
2e60b90 
Fixes amoffat#708

glob.glob has many possible arguments but the current wrapping solution
doesn't cover all them.

This change directly passes all args (positional and kw) as-is to the
wrapped function.
@AaronDMarasco AaronDMarasco mentioned this issue May 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix glob Pistahh/python-sh
2 participants
@amoffat @Pistahh