Make fd/file_chunk_consumer respect decode_errors #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the example I provided at amoffat#556 (comment) by making fd/file_chunk_consumer respect decode_errors just like the other consumers.
|
Thanks for this! It looks good. It would be great if we can get some test coverage of this. There's a |
felixonmars
force-pushed
the
decode_errors
branch
from
068a8eb to
fab2bbd
Compare
Also added some latin-1 encoded bytes to make it always invalid for sys.stdout too.
felixonmars
force-pushed
the
decode_errors
branch
from
fab2bbd to
bccde9a
Compare
|
I have adjusted the test case to correctly cover this. |
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the example I provided at
#556 (comment) by making fd/file_chunk_consumer respect decode_errors just like the other consumers.