Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confirm default flag without ask for now #34

Closed
wants to merge 1 commit into from

Conversation

foxundermoon
Copy link

it will be hanging with confirming in the new version now.

https://github.com/WeFoxTech/website/runs/467013502?check_suite_focus=true

add -c flag to the default command args.

@amondnet amondnet assigned amondnet and unassigned amondnet Feb 26, 2020
@amondnet amondnet added the Type: Bug Bug or Bug fixes label Feb 26, 2020
@amondnet amondnet added this to the v1.2.1 milestone Feb 26, 2020
@amondnet amondnet self-requested a review February 26, 2020 12:11
amondnet
amondnet previously approved these changes Feb 26, 2020
@amondnet amondnet changed the base branch from master to release/v1.2.1 February 26, 2020 12:12
@amondnet amondnet changed the base branch from release/v1.2.1 to master February 26, 2020 12:12
@amondnet amondnet self-requested a review February 26, 2020 12:32
@amondnet
Copy link
Owner

@foxundermoon
Thanks for your contributing. This is related to #23, #24, #26. I added new options(now-project-id and now-org-id) since v2.0.0.
Can we use --confirm(-c) and these options?
Or should we use -c and log warning if now-project-id and now-org-id is missing? I'll wait for your feedback.

@foxundermoon
Copy link
Author

ok it's better than --confirm :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Bug or Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants