fix: Commit messages aren't fully shell escaped

`foo`, 'bar', "baz" close #164 close #162 Signed-off-by: Minsu Lee <amond@amond.net>
amondnet · Jun 27, 2022 · 8ed64b8 · 8ed64b8
1 parent cda7aa8
commit 8ed64b8
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 4 deletions.
diff --git a/dist/index.js b/dist/index.js
diff --git a/index.js b/index.js
@@ -132,7 +132,12 @@ async function vercelDeploy(ref, commit) {
     ...addVercelMetadata('githubRepo', context.repo.repo, providedArgs),
     ...addVercelMetadata('githubCommitOrg', context.repo.owner, providedArgs),
     ...addVercelMetadata('githubCommitRepo', context.repo.repo, providedArgs),
-    ...addVercelMetadata('githubCommitMessage', `"${commit}"`, providedArgs),
+    ...addVercelMetadata(
+      'githubCommitMessage',
+      // eslint-disable-next-line prefer-template
+      '"' + commit + '"',
+      providedArgs,
+    ),
     ...addVercelMetadata(
       'githubCommitRef',
       ref.replace('refs/heads/', ''),

diff --git a/package.json b/package.json
@@ -11,7 +11,7 @@
     "email": "amond@amond.net",
     "url": "https://amond.dev"
   },
-  "version": "25.0.0",
+  "version": "25.0.1",
   "main": "index.js",
   "scripts": {
     "lint": "eslint index.js",