Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let the Vercel CLI do the build #123

Open
PaulRBerg opened this issue Mar 7, 2022 · 4 comments
Open

Let the Vercel CLI do the build #123

PaulRBerg opened this issue Mar 7, 2022 · 4 comments

Comments

@PaulRBerg
Copy link

As per the Vercel CLI docs as of March 2022, it is no longer recommended to provide the builds field ourselves. Instead, the functions field should be used, but only when a Serverless Function is due to be deployed. For all other cases, the Vercel CLI should handle the build by itself, given that it knows what steps to run based on the project id (or at least this is what I understand by reading the docs, someone please correct me if I'm wrong).

Whatever the case, it's clear that builds and routes should not be used anymore:

Vercel CLI docs screenshot

@amondnet
Copy link
Owner

amondnet commented Mar 9, 2022

Yes, routes should be changed to rewrites. But we don't use vercel's build system, so we have to use builds. We don't even need to use builds.

@PaulRBerg
Copy link
Author

We don't even need to use builds.

That's what I wanted to say in reply to your now striken-through text 😅 I just integrated your GitHub Action and skipped the builds field and deployments are working just fine.

Should the README be updated to remove the builds field?

@amondnet
Copy link
Owner

@PaulRBerg

That's what I wanted to say in reply to your now striken-through text 😅 I just integrated your GitHub Action and skipped the builds field and deployments are working just fine.

https://vercel.com/dashboard/usage

Because you use vercel build, you use vercel build time in addition to github actions. It also has some limitations. If your build takes a long time and you do multiple builds, you will see a lot of queues. Hobby plan does only one build at a time.

If that's okay with you, you can.

@PaulRBerg
Copy link
Author

PaulRBerg commented Mar 10, 2022

If your build takes a long time and you do multiple builds, you will see a lot of queues

yeah I'm already starting to see the queues ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants